Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/189913

Change subject: [DO NOT SUBMIT] testing jenkins after +1
......................................................................

[DO NOT SUBMIT] testing jenkins after +1

Change-Id: I33f749680e48ca9f911d5e5c18e735c0960ea6ee
---
M tests/site_tests.py
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/13/189913/1

diff --git a/tests/site_tests.py b/tests/site_tests.py
index d8daebf..cbf6815 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1325,15 +1325,12 @@
     """Test random methods of a site."""
 
     def test_unlimited_small_step(self):
-        """Test site.randompages() continuation.
-
-        Note that uniqueness is not guaranteed if multiple requests are
-        performed, so we also don't test this here.
-        """
+        """Test site.randompages() without limit."""
         mysite = self.get_site()
         pages = []
         for rndpage in mysite.randompages(step=5, total=None):
             self.assertIsInstance(rndpage, pywikibot.Page)
+            self.assertNotIn(rndpage, pages)
             pages.append(rndpage)
             if len(pages) == 11:
                 break

-- 
To view, visit https://gerrit.wikimedia.org/r/189913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I33f749680e48ca9f911d5e5c18e735c0960ea6ee
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>
Gerrit-Reviewer: Pywikipedia Conversion Bot <valhall...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to