Markus Kroetzsch has uploaded a new change for review.

Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...)
......................................................................

Fix sortkey retrieval in Store3 (Bug 42033, ...)

Since sortkeys are not stored in a property table, but in the SMW IDs table, 
methods need special code to handle them. This was missing everywhere, but has 
a practical impact only for getPropertyValues(). Where unexpected, this caused 
warnings and errors (Bug 42033, Bug 42034) but also spurious problems with 
ordering of results (only in certain cases).

The change fixes this for getPropertyValues and adds remarks/todos in all cases 
where sortkeys are not currently supported (but not practically needed either).

Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
---
M includes/storage/SQLStore/SMW_SQLStore3_Queries.php
M includes/storage/SQLStore/SMW_SQLStore3_Readers.php
2 files changed, 27 insertions(+), 4 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki 
refs/changes/81/33081/1
--
To view, visit https://gerrit.wikimedia.org/r/33081
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to