Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...) ......................................................................
Fix sortkey retrieval in Store3 (Bug 42033, ...) Since sortkeys are not stored in a property table, but in the SMW IDs table, methods need special code to handle them. This was missing everywhere, but has a practical impact only for getPropertyValues(). Where unexpected, this caused warnings and errors (Bug 42033, Bug 42034) but also spurious problems with ordering of results (only in certain cases). The change fixes this for getPropertyValues and adds remarks/todos in all cases where sortkeys are not currently supported (but not practically needed either). Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 2 files changed, 27 insertions(+), 4 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/33081 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de> Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de> Gerrit-Reviewer: Foxtrott <s7ep...@gmail.com> Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com> Gerrit-Reviewer: Kghbln <mediaw...@kghoffmeyer.de> Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org> Gerrit-Reviewer: Mwjames <jamesin.hongkon...@gmail.com> Gerrit-Reviewer: Nischayn22 <nischay...@gmail.com> Gerrit-Reviewer: Yaron Koren <yaro...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
