Fjalapeno has uploaded a new change for review.
https://gerrit.wikimedia.org/r/202797
Change subject: add wmf prefix to category methods (messed up the last patch
and didn't commit it)
......................................................................
add wmf prefix to category methods (messed up the last patch and didn't commit
it)
Change-Id: Ie94331d110c65dff5165dd53c0bf090cdbe1e4e0
---
M Wikipedia/AppDelegate.m
M wikipedia/Categories/BITHockeyManager+WMFExtensions.h
M wikipedia/Categories/BITHockeyManager+WMFExtensions.m
3 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia
refs/changes/97/202797/1
diff --git a/Wikipedia/AppDelegate.m b/Wikipedia/AppDelegate.m
index 03b6bb8..9de2b4e 100644
--- a/Wikipedia/AppDelegate.m
+++ b/Wikipedia/AppDelegate.m
@@ -25,7 +25,7 @@
}
- (BOOL)application:(UIApplication*)application
didFinishLaunchingWithOptions:(NSDictionary*)launchOptions {
- [[BITHockeyManager sharedHockeyManager] setupAndStart];
+ [[BITHockeyManager sharedHockeyManager] wmf_setupAndStart];
[self systemWideStyleOverrides];
diff --git a/wikipedia/Categories/BITHockeyManager+WMFExtensions.h
b/wikipedia/Categories/BITHockeyManager+WMFExtensions.h
index b7bd5fc..1fc07a1 100644
--- a/wikipedia/Categories/BITHockeyManager+WMFExtensions.h
+++ b/wikipedia/Categories/BITHockeyManager+WMFExtensions.h
@@ -4,22 +4,22 @@
@interface BITHockeyManager (WMFExtensions)
/**
- * Configure and startup in on line.
+ * Configure and startup in one line.
* This will call the methods below as part of the configuration process.
* This method will use the current bundle id of the app
*/
-- (void)setupAndStart;
+- (void)wmf_setupAndStart;
/**
* Set the Hockey API Key based on a bundle ID
*
* @param bundleID The bundle ID to map to an API Key
*/
-- (void)setAPIKeyForBundleID:(NSString*)bundleID;
+- (void)wmf_setAPIKeyForBundleID:(NSString*)bundleID;
/**
* Configure the alert to be displayed when a user is prompeted to send a
crash report
*/
-- (void)setupCrashNotificationAlert;
+- (void)wmf_setupCrashNotificationAlert;
@end
diff --git a/wikipedia/Categories/BITHockeyManager+WMFExtensions.m
b/wikipedia/Categories/BITHockeyManager+WMFExtensions.m
index 3edf4d1..18493ab 100644
--- a/wikipedia/Categories/BITHockeyManager+WMFExtensions.m
+++ b/wikipedia/Categories/BITHockeyManager+WMFExtensions.m
@@ -42,19 +42,19 @@
return MWLocalizedString(kHockeyAppDoNotSendStringsKey, nil);
}
-- (void)setupAndStart {
+- (void)wmf_setupAndStart {
NSString* bundleID = [WikipediaAppUtils bundleID];
- [[BITHockeyManager sharedHockeyManager] setAPIKeyForBundleID:bundleID];
+ [[BITHockeyManager sharedHockeyManager] wmf_setAPIKeyForBundleID:bundleID];
[[BITHockeyManager sharedHockeyManager] startManager];
[[BITHockeyManager sharedHockeyManager].authenticator
authenticateInstallation];
- [[BITHockeyManager sharedHockeyManager] setupCrashNotificationAlert];
+ [[BITHockeyManager sharedHockeyManager] wmf_setupCrashNotificationAlert];
}
-- (void)setAPIKeyForBundleID:(NSString*)bundleID {
+- (void)wmf_setAPIKeyForBundleID:(NSString*)bundleID {
NSString* crashReportingAppID = [[self class]
crashReportingIDFor:bundleID];
if (!crashReportingAppID) {
return;
@@ -62,7 +62,7 @@
[[BITHockeyManager sharedHockeyManager]
configureWithIdentifier:crashReportingAppID];
}
-- (void)setupCrashNotificationAlert {
+- (void)wmf_setupCrashNotificationAlert {
[[BITHockeyManager sharedHockeyManager].crashManager
setAlertViewHandler:^(){
NSString* title = [MWLocalizedString(kHockeyAppTitleStringsKey, nil)
stringByReplacingOccurrencesOfString:@"$1"
withString:WMFHockeyAppServiceName];
--
To view, visit https://gerrit.wikimedia.org/r/202797
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie94331d110c65dff5165dd53c0bf090cdbe1e4e0
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Fjalapeno <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
