Dzahn has uploaded a new change for review. https://gerrit.wikimedia.org/r/202798
Change subject: fix check_eth icinga plugin ...................................................................... fix check_eth icinga plugin The "configured eth" checks in Icinga are currently: OK but also "NRPE: Unable to read output" as decribed in T92293. This is because it's simply not echoing a string when things are OK. https://icinga.wikimedia.org/cgi-bin/icinga/status.cgi?search_string=configured+eth Besides this quick fix, it would be better design for icinga plugins if we check explicitely for things to be OK and else exit with a warning instead of checking for known error conditions and defaulting to OK. Bug:T92293 Change-Id: I828e805600721f78cf852aeaeff25eece8b93b97 --- M modules/base/templates/check_eth.erb 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/98/202798/1 diff --git a/modules/base/templates/check_eth.erb b/modules/base/templates/check_eth.erb index 66f0eb8..3f88702 100644 --- a/modules/base/templates/check_eth.erb +++ b/modules/base/templates/check_eth.erb @@ -25,4 +25,5 @@ fi fi done +echo "OK - interfaces up" exit $EXIT_CODE -- To view, visit https://gerrit.wikimedia.org/r/202798 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I828e805600721f78cf852aeaeff25eece8b93b97 Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
