Chad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/203968

Change subject: More useful debugging information on unsafe tag attributes
......................................................................

More useful debugging information on unsafe tag attributes

Bug: T94900
Change-Id: Ifa6d11a433a6c267a6b3cbcb2415bf61013a2ef6
---
M php/Tag.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/68/203968/1

diff --git a/php/Tag.php b/php/Tag.php
index 50fffc4..2672ffa 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -313,7 +313,7 @@
                                // @codingStandardsIgnoreEnd
 
                                if ( !( $scheme === null || in_array( 
strtolower( $scheme ), $protocolWhitelist ) ) ) {
-                                       throw new Exception( "Potentially 
unsafe '$key' attribute value" );
+                                       throw new Exception( "Potentially 
unsafe '$key' attribute value. Scheme: '$scheme'; value: '$value'." );
                                }
                        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/203968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifa6d11a433a6c267a6b3cbcb2415bf61013a2ef6
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to