jenkins-bot has submitted this change and it was merged.
Change subject: More useful debugging information on unsafe tag attributes
......................................................................
More useful debugging information on unsafe tag attributes
Bug: T94900
Change-Id: Ifa6d11a433a6c267a6b3cbcb2415bf61013a2ef6
---
M php/Tag.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/php/Tag.php b/php/Tag.php
index 50fffc4..da8c2bf 100644
--- a/php/Tag.php
+++ b/php/Tag.php
@@ -313,7 +313,8 @@
// @codingStandardsIgnoreEnd
if ( !( $scheme === null || in_array(
strtolower( $scheme ), $protocolWhitelist ) ) ) {
- throw new Exception( "Potentially
unsafe '$key' attribute value" );
+ throw new Exception( "Potentially
unsafe '$key' attribute value. " .
+ "Scheme: '$scheme'; value:
'$value'." );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/203968
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifa6d11a433a6c267a6b3cbcb2415bf61013a2ef6
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
