Cscott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/207900
Change subject: Remove vestigial reset() methods in Cite.
......................................................................
Remove vestigial reset() methods in Cite.
Cite is now stateless and should remain so!
Change-Id: Ib90cb1da8cb809f6fec9410ff6fb00c32e276dcf
---
M lib/ext.Cite.js
1 file changed, 1 insertion(+), 14 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/00/207900/1
diff --git a/lib/ext.Cite.js b/lib/ext.Cite.js
index c0336bb..f67af06 100644
--- a/lib/ext.Cite.js
+++ b/lib/ext.Cite.js
@@ -64,14 +64,7 @@
*/
function Ref(cite) {
this.cite = cite;
- this.reset();
}
-
-/**
- * Reset state before each top-level parse -- this lets us share a pipeline
- * to parse unrelated pages.
- */
-Ref.prototype.reset = function() { };
function hasRef(node) {
var c = node.firstChild;
@@ -286,10 +279,7 @@
function References(cite) {
this.cite = cite;
- this.reset();
}
-
-References.prototype.reset = function() {};
/**
* Sanitize the references tag and convert it into a meta-token
@@ -539,10 +529,7 @@
};
Cite.prototype.resetState = function(opts) {
- if (opts && opts.toplevel) {
- this.ref.reset();
- this.references.reset();
- }
+ /* FIXME: Cite should be stateless; see T93974 */
};
if (typeof module === "object") {
--
To view, visit https://gerrit.wikimedia.org/r/207900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib90cb1da8cb809f6fec9410ff6fb00c32e276dcf
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
