jenkins-bot has submitted this change and it was merged.
Change subject: Remove vestigial reset() methods in Cite.
......................................................................
Remove vestigial reset() methods in Cite.
Cite is now stateless and should remain so!
Change-Id: Ib90cb1da8cb809f6fec9410ff6fb00c32e276dcf
---
M lib/ext.Cite.js
1 file changed, 0 insertions(+), 17 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
Cscott: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/ext.Cite.js b/lib/ext.Cite.js
index c0336bb..6ac2632 100644
--- a/lib/ext.Cite.js
+++ b/lib/ext.Cite.js
@@ -64,14 +64,7 @@
*/
function Ref(cite) {
this.cite = cite;
- this.reset();
}
-
-/**
- * Reset state before each top-level parse -- this lets us share a pipeline
- * to parse unrelated pages.
- */
-Ref.prototype.reset = function() { };
function hasRef(node) {
var c = node.firstChild;
@@ -286,10 +279,7 @@
function References(cite) {
this.cite = cite;
- this.reset();
}
-
-References.prototype.reset = function() {};
/**
* Sanitize the references tag and convert it into a meta-token
@@ -536,13 +526,6 @@
var Cite = function() {
this.ref = new Ref(this);
this.references = new References(this);
-};
-
-Cite.prototype.resetState = function(opts) {
- if (opts && opts.toplevel) {
- this.ref.reset();
- this.references.reset();
- }
};
if (typeof module === "object") {
--
To view, visit https://gerrit.wikimedia.org/r/207900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib90cb1da8cb809f6fec9410ff6fb00c32e276dcf
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Cscott <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
