Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/208936

Change subject: Prevent Alt+S being consumed by CX
......................................................................

Prevent Alt+S being consumed by CX

See 
https://medium.com/medium-eng/the-curious-case-of-disappearing-polish-s-fa398313d4df
Also removed redundant e.preventDefault since
the handler is already returning false

Change-Id: I5b5571f8a5c3e5101583cf56837f8f7c4f4722da
---
M modules/draft/ext.cx.draft.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/36/208936/1

diff --git a/modules/draft/ext.cx.draft.js b/modules/draft/ext.cx.draft.js
index bd23623..a3689b9 100644
--- a/modules/draft/ext.cx.draft.js
+++ b/modules/draft/ext.cx.draft.js
@@ -77,8 +77,8 @@
 
                // Save when CTRL+S is pressed.
                $( document ).on( 'keydown', function ( e ) {
-                       if ( e.ctrlKey && e.which === 83 ) {
-                               e.preventDefault();
+                       // See 
https://medium.com/medium-eng/the-curious-case-of-disappearing-polish-s-fa398313d4df
+                       if ( ( e.metaKey || e.ctrlKey && !e.altKey ) && e.which 
=== 83 ) {
                                checkAndsave();
                                return false;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/208936
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b5571f8a5c3e5101583cf56837f8f7c4f4722da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to