jenkins-bot has submitted this change and it was merged. Change subject: Prevent Alt+S being consumed by CX ......................................................................
Prevent Alt+S being consumed by CX See https://medium.com/medium-eng/the-curious-case-of-disappearing-polish-s-fa398313d4df Also removed redundant e.preventDefault because the handler is already returning false. Change-Id: I5b5571f8a5c3e5101583cf56837f8f7c4f4722da --- M modules/draft/ext.cx.draft.js 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Amire80: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/draft/ext.cx.draft.js b/modules/draft/ext.cx.draft.js index bd23623..a3689b9 100644 --- a/modules/draft/ext.cx.draft.js +++ b/modules/draft/ext.cx.draft.js @@ -77,8 +77,8 @@ // Save when CTRL+S is pressed. $( document ).on( 'keydown', function ( e ) { - if ( e.ctrlKey && e.which === 83 ) { - e.preventDefault(); + // See https://medium.com/medium-eng/the-curious-case-of-disappearing-polish-s-fa398313d4df + if ( ( e.metaKey || e.ctrlKey && !e.altKey ) && e.which === 83 ) { checkAndsave(); return false; } -- To view, visit https://gerrit.wikimedia.org/r/208936 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b5571f8a5c3e5101583cf56837f8f7c4f4722da Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
