jenkins-bot has submitted this change and it was merged.
Change subject: registration: Don't array_unique() over the queue before
loading it
......................................................................
registration: Don't array_unique() over the queue before loading it
array_unique works over values, not keys (you can't have an array with
duplicate keys in PHP) so it would end up removing extensions that
happened to have an identical timestamp with another one.
Bug: T98956
Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
---
M includes/registration/ExtensionRegistry.php
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Tim Starling: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/registration/ExtensionRegistry.php
b/includes/registration/ExtensionRegistry.php
index d938f07..4836275 100644
--- a/includes/registration/ExtensionRegistry.php
+++ b/includes/registration/ExtensionRegistry.php
@@ -90,8 +90,6 @@
return;
}
- $this->queued = array_unique( $this->queued );
-
// See if this queue is in APC
$key = wfMemcKey( 'registration', md5( json_encode(
$this->queued ) ) );
$data = $this->cache->get( $key );
--
To view, visit https://gerrit.wikimedia.org/r/211946
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
