Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/211947
Change subject: registration: Don't array_unique() over the queue before
loading it
......................................................................
registration: Don't array_unique() over the queue before loading it
array_unique works over values, not keys (you can't have an array with
duplicate keys in PHP) so it would end up removing extensions that
happened to have an identical timestamp with another one.
Bug: T98956
Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
(cherry picked from commit 1be36f6356bc6fd76586518001bc76c3d9b9aa14)
---
M includes/registration/ExtensionRegistry.php
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/47/211947/1
diff --git a/includes/registration/ExtensionRegistry.php
b/includes/registration/ExtensionRegistry.php
index d938f07..4836275 100644
--- a/includes/registration/ExtensionRegistry.php
+++ b/includes/registration/ExtensionRegistry.php
@@ -90,8 +90,6 @@
return;
}
- $this->queued = array_unique( $this->queued );
-
// See if this queue is in APC
$key = wfMemcKey( 'registration', md5( json_encode(
$this->queued ) ) );
$data = $this->cache->get( $key );
--
To view, visit https://gerrit.wikimedia.org/r/211947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e202ea882ae4d5cb1bcafb7882cbd9cd52a1b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.26wmf6
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
