Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/213492

Change subject: mediawiki.ui: checkbox: Render "on top of" the label
......................................................................

mediawiki.ui: checkbox: Render "on top of" the label

To fix clickability with checkboxShiftClick.

Bug: T98905
Change-Id: I2a2dbfb6c8be991a79d8d63c9119387be1675d64
---
M resources/src/mediawiki.ui/components/checkbox.less
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/92/213492/1

diff --git a/resources/src/mediawiki.ui/components/checkbox.less 
b/resources/src/mediawiki.ui/components/checkbox.less
index 4829f5f..ac5becb 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -54,6 +54,9 @@
                // we hide the input element as instead we will style the label 
that follows
                // we use opacity so that VoiceOver software can still identify 
it
                opacity: 0;
+               // Render "on top of" the label, so that it's still clickable 
(T98905)
+               z-index: 1;
+               position: relative;
                // ensure the invisible checkbox takes up the required width
                width: @checkboxSize;
                height: @checkboxSize;

-- 
To view, visit https://gerrit.wikimedia.org/r/213492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a2dbfb6c8be991a79d8d63c9119387be1675d64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to