jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.ui: checkbox: Render "on top of" the label
......................................................................
mediawiki.ui: checkbox: Render "on top of" the label
To fix clickability with checkboxShiftClick.
Bug: T98905
Change-Id: I2a2dbfb6c8be991a79d8d63c9119387be1675d64
---
M resources/src/mediawiki.ui/components/checkbox.less
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.ui/components/checkbox.less
b/resources/src/mediawiki.ui/components/checkbox.less
index 4829f5f..ac5becb 100644
--- a/resources/src/mediawiki.ui/components/checkbox.less
+++ b/resources/src/mediawiki.ui/components/checkbox.less
@@ -54,6 +54,9 @@
// we hide the input element as instead we will style the label
that follows
// we use opacity so that VoiceOver software can still identify
it
opacity: 0;
+ // Render "on top of" the label, so that it's still clickable
(T98905)
+ z-index: 1;
+ position: relative;
// ensure the invisible checkbox takes up the required width
width: @checkboxSize;
height: @checkboxSize;
--
To view, visit https://gerrit.wikimedia.org/r/213492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2a2dbfb6c8be991a79d8d63c9119387be1675d64
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Edokter <er...@darcoury.nl>
Gerrit-Reviewer: Jack Phoenix <j...@countervandalism.net>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
