Santhosh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/217453

Change subject: Avoid save error when translation started with empty content
......................................................................

Avoid save error when translation started with empty content

If the language directions are different the translation template is
blank, but it will trigger a translation change event and in turn a
save event. Do a check for empty content before firing api.

Change-Id: I131bf12549ea02998c03eba48f7facafd9cf5139
---
M modules/draft/ext.cx.draft.js
1 file changed, 11 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation 
refs/changes/53/217453/1

diff --git a/modules/draft/ext.cx.draft.js b/modules/draft/ext.cx.draft.js
index 4fbdbf3..3add12c 100644
--- a/modules/draft/ext.cx.draft.js
+++ b/modules/draft/ext.cx.draft.js
@@ -206,6 +206,17 @@
                        progress: JSON.stringify( mw.cx.getProgress() )
                };
 
+               if ( !params.html ) {
+                       // No content to save. But dont let the save initiator 
wait infinitely.
+                       mw.hook( 'mw.cx.translation.saved' ).fire(
+                               mw.cx.sourceLanguage,
+                               mw.cx.targetLanguage,
+                               mw.cx.sourceTitle,
+                               targetTitle
+                       );
+
+                       return;
+               }
                apiParams = $.extend( {}, params, {
                        action: 'cxpublish'
                } );

-- 
To view, visit https://gerrit.wikimedia.org/r/217453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I131bf12549ea02998c03eba48f7facafd9cf5139
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to