jenkins-bot has submitted this change and it was merged.
Change subject: Avoid save error when translation started with empty content
......................................................................
Avoid save error when translation started with empty content
If the language directions are different the translation template is
blank, but clicking a placeholder triggers a translation change event
and in turn a save event.
Do a check for empty content before firing API.
Change-Id: I131bf12549ea02998c03eba48f7facafd9cf5139
---
M modules/draft/ext.cx.draft.js
1 file changed, 12 insertions(+), 0 deletions(-)
Approvals:
Amire80: Looks good to me, but someone else must approve
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/draft/ext.cx.draft.js b/modules/draft/ext.cx.draft.js
index 4fbdbf3..c628510 100644
--- a/modules/draft/ext.cx.draft.js
+++ b/modules/draft/ext.cx.draft.js
@@ -206,6 +206,18 @@
progress: JSON.stringify( mw.cx.getProgress() )
};
+ if ( !params.html ) {
+ // There's no content to save,
+ // but don't let the save initiator wait infinitely
+ mw.hook( 'mw.cx.translation.saved' ).fire(
+ mw.cx.sourceLanguage,
+ mw.cx.targetLanguage,
+ mw.cx.sourceTitle,
+ targetTitle
+ );
+
+ return;
+ }
apiParams = $.extend( {}, params, {
action: 'cxpublish'
} );
--
To view, visit https://gerrit.wikimedia.org/r/217453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I131bf12549ea02998c03eba48f7facafd9cf5139
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
