jenkins-bot has submitted this change and it was merged. Change subject: Avoid using same error message for save and publish ......................................................................
Avoid using same error message for save and publish Change-Id: Id7af6406c5ebf734e02840bc4bad73009be0ebbe --- M Resources.php M i18n/en.json M i18n/qqq.json M modules/draft/ext.cx.draft.js 4 files changed, 4 insertions(+), 1 deletion(-) Approvals: KartikMistry: Looks good to me, approved Amire80: Looks good to me, approved jenkins-bot: Verified diff --git a/Resources.php b/Resources.php index 6213de7..c352f32 100644 --- a/Resources.php +++ b/Resources.php @@ -519,6 +519,7 @@ 'messages' => array( 'cx-save-draft-saving', 'cx-save-draft-save-success', + 'cx-save-draft-error', 'cx-save-draft-tooltip', ), ) + $resourcePaths; diff --git a/i18n/en.json b/i18n/en.json index 9c8f477..04fa1d8 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -138,6 +138,7 @@ "cx-save-draft-save-success": "Saved {{PLURAL:$1|a minute ago|$1 minutes ago|0=just now}}", "cx-save-draft-saving": "Saving...", "cx-save-draft-tooltip": "Translation drafts are saved automatically", + "cx-save-draft-error": "An error occurred while saving the page.", "cx-contributions-new-contributions": "New contribution", "cx-contributions-new-article": "New page", "cx-contributions-translation": "Translation", diff --git a/i18n/qqq.json b/i18n/qqq.json index 7372f52..7ff7d81 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -142,6 +142,7 @@ "cx-save-draft-save-success": "\"Saved\" refers to a draft of a translated page that was saved recently.", "cx-save-draft-saving": "Label of button to save the translation as draft while saving is in progress\n{{Identical|Saving}}", "cx-save-draft-tooltip": "Tooltip text shown for the save status indicator text in the header of [[Special:ContentTranslation]].\n\nParameters: \n* $1 - the number of minutes ago the translation was saved.", + "cx-save-draft-error": "Error message shown if saving page draft failed.", "cx-contributions-new-contributions": "Header text shown in [[Special:Contributions]]", "cx-contributions-new-article": "Button label tooltip\n{{Identical|New page}}", "cx-contributions-translation": "Button label tooltip", diff --git a/modules/draft/ext.cx.draft.js b/modules/draft/ext.cx.draft.js index a3689b9..4fbdbf3 100644 --- a/modules/draft/ext.cx.draft.js +++ b/modules/draft/ext.cx.draft.js @@ -222,7 +222,7 @@ checkAndsave(); }, 5 * 60 * 1000 ); } ).fail( function () { - mw.hook( 'mw.cx.error' ).fire( mw.msg( 'cx-publish-page-error' ) ); + mw.hook( 'mw.cx.error' ).fire( mw.msg( 'cx-save-draft-error' ) ); } ); }; -- To view, visit https://gerrit.wikimedia.org/r/217452 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7af6406c5ebf734e02840bc4bad73009be0ebbe Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com> Gerrit-Reviewer: Siebrand <siebr...@kitano.nl> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits