Gerrit Patch Uploader has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/218385

Change subject: Repair search button
......................................................................

Repair search button

Bug: T102486
Change-Id: I452147dd12ff46e08fbce0646090f979510ae3f8
---
M modules/jquery.codeEditor.js
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeEditor 
refs/changes/85/218385/1

diff --git a/modules/jquery.codeEditor.js b/modules/jquery.codeEditor.js
index cef2f21..101c31d 100644
--- a/modules/jquery.codeEditor.js
+++ b/modules/jquery.codeEditor.js
@@ -56,7 +56,6 @@
                context.showInvisibleChars = ( cookieEnabled === 1 );
                cookieEnabled = parseInt( mw.cookie.get( 'codeEditor-' + 
context.instance + '-lineWrappingActive' ), 10 );
                context.lineWrappingActive = ( cookieEnabled === 1 );
-               context.showSearchReplace = 0;
 
                /*
                 * Event Handlers
@@ -165,12 +164,10 @@
                                        context.codeEditor.setShowInvisibles( 
context.showInvisibleChars );
                                };
                                toggleSearchReplace = function ( context ) {
-                                       context.showSearchReplace = 
!context.showSearchReplace;
-
-                                       if ( context.showSearchReplace ) {
+                                       if ( !context.codeEditor.searchBox || 
!context.codeEditor.searchBox.isFocused() ) {
                                                ace.config.loadModule( 
'ace/ext/searchbox', function ( e ) {
                                                        // 
ace.editor.searchBox.show();
-                                                       e.Search( 
context.codeEditor, !0 );
+                                                       e.Search( 
context.codeEditor );
                                                } );
                                        } else {
                                                
context.codeEditor.searchBox.hide();

-- 
To view, visit https://gerrit.wikimedia.org/r/218385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I452147dd12ff46e08fbce0646090f979510ae3f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <gerritpatchuploa...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to