Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/218387
Change subject: Add more tests for statementview js
......................................................................
Add more tests for statementview js
this provides more test coverage for the isValid method,
though this doesn't exactly test for the issue in T98471.
(I am not quite sure how to use sinon or otherwise test for
T98471 properly and need to investigate more)
Change-Id: I39130763b1286346a7576b17867c879aa1db2942
---
M view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/87/218387/1
diff --git
a/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
b/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
index c683a55..5df64ff 100644
--- a/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
+++ b/view/tests/qunit/jquery/wikibase/jquery.wikibase.statementview.tests.js
@@ -118,6 +118,13 @@
assert.ok( statementview.isValid(), 'isValid should return true' );
} );
+QUnit.test( 'isValid on new statementview is false', function( assert ) {
+ var $statementview = createStatementview(),
+ statementview = $statementview.data( 'statementview' );
+
+ assert.ok( statementview.isValid() === false, 'isValid should return
false' );
+} );
+
QUnit.test( 'remove', function( assert ) {
var referencesChanger = {
removeReference: sinon.spy( function() { return
$.Deferred().resolve().promise(); } )
--
To view, visit https://gerrit.wikimedia.org/r/218387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39130763b1286346a7576b17867c879aa1db2942
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
