Krinkle has submitted this change and it was merged. Change subject: (bug 42638) Fix API action=options&reset=1 & unit tests ......................................................................
(bug 42638) Fix API action=options&reset=1 & unit tests Change I98df55f2 broke action=options&reset=1, causing it to return an error "No changes were requested" rather than resetting the options as it should. Unfortunately, that change also broke the unit test that would have caught this regression. This changeset fixes the bug and the unit tests. Change-Id: I7fe63640d54efab4572538e9d08f5b75c61243a4 --- M includes/api/ApiOptions.php M tests/phpunit/includes/api/ApiOptionsTest.php 2 files changed, 58 insertions(+), 20 deletions(-) Approvals: Krinkle: Looks good to me, approved CSteipp: Looks good to me, but someone else must approve Catrope: Looks good to me, but someone else must approve jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/36493 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7fe63640d54efab4572538e9d08f5b75c61243a4 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: Anomie <bjor...@wikimedia.org> Gerrit-Reviewer: CSteipp <cste...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: Demon <ch...@wikimedia.org> Gerrit-Reviewer: Krinkle <ttij...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
