jenkins-bot has submitted this change and it was merged.
Change subject: [rountrip-test] Handle titles that parse as ints in cli
......................................................................
[rountrip-test] Handle titles that parse as ints in cli
* ex. enwiki/1984
Change-Id: Ic6a0ad2546d37eb0e09a0d7d841ac8bd897eed51
---
M tests/roundtrip-test.js
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/roundtrip-test.js b/tests/roundtrip-test.js
index 5cbfd28..5f4770a 100755
--- a/tests/roundtrip-test.js
+++ b/tests/roundtrip-test.js
@@ -687,11 +687,10 @@
).check(Util.checkUnknownArgs.bind(null, options));
var argv = opts.argv;
- var title = argv._[0];
-
- if (!title) {
+ if (!argv._.length) {
return opts.showHelp();
}
+ var title = String(argv._[0]);
Promise.resolve().then(function() {
if (argv.parsoidURL) { return; }
--
To view, visit https://gerrit.wikimedia.org/r/230964
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6a0ad2546d37eb0e09a0d7d841ac8bd897eed51
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
