Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/237976

Change subject: Made attemptAddUser() explicity make sure the central DB is up
......................................................................

Made attemptAddUser() explicity make sure the central DB is up

* Once slaves are used more, this check will make a difference
  in terms of handling central DB master outages

Change-Id: I05c93ffdd417a1e7ec10040252c9a7742fa25e18
---
M includes/CentralAuthHooks.php
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralAuth 
refs/changes/76/237976/1

diff --git a/includes/CentralAuthHooks.php b/includes/CentralAuthHooks.php
index 18d256b..ad62f64 100644
--- a/includes/CentralAuthHooks.php
+++ b/includes/CentralAuthHooks.php
@@ -1193,6 +1193,9 @@
                $from = isset( $_SERVER['REQUEST_URI'] ) ? 
$_SERVER['REQUEST_URI'] : 'CLI';
                wfDebugLog( 'CentralAuth-Bug39996', __METHOD__ . ": creating 
new user ($userName) - from: $from\n" );
                try {
+                       // Make sure the central DB master is availabe
+                       CentralAuthUser::getCentralDB();
+                       // Insert the user into the local DB master
                        $status = $user->addToDatabase();
                } catch ( Exception $e ) {
                        wfDebugLog( 'CentralAuth-Bug39996', __METHOD__ . " 
User::addToDatabase for \"$userName\" threw an exception:"

-- 
To view, visit https://gerrit.wikimedia.org/r/237976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I05c93ffdd417a1e7ec10040252c9a7742fa25e18
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to