jenkins-bot has submitted this change and it was merged.

Change subject: SpecialPagesWithProp: convert implicit join into join_conds
......................................................................


SpecialPagesWithProp: convert implicit join into join_conds

Bug: T71083
Change-Id: Ic36ecd33a9b4b2ad8b3ca24fabbe496c5207b28f
---
M includes/specials/SpecialPagesWithProp.php
1 file changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Umherirrender: Looks good to me, approved
  Nemo bis: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/includes/specials/SpecialPagesWithProp.php 
b/includes/specials/SpecialPagesWithProp.php
index 26d0fe8..f211ec9 100644
--- a/includes/specials/SpecialPagesWithProp.php
+++ b/includes/specials/SpecialPagesWithProp.php
@@ -113,9 +113,11 @@
                                'pp_value',
                        ),
                        'conds' => array(
-                               'page_id = pp_page',
                                'pp_propname' => $this->propName,
                        ),
+                       'join_conds' => array(
+                               'page' => array( 'INNER JOIN', 'page_id = 
pp_page' )
+                       ),
                        'options' => array()
                );
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/233202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic36ecd33a9b4b2ad8b3ca24fabbe496c5207b28f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisa...@openmailbox.org>
Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: PleaseStand <pleasest...@live.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to