Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/239517
Change subject: Add navigation drawer shadow ...................................................................... Add navigation drawer shadow Add a soft subtle shadow to the navigation drawer for consistent appearance on API 15[0] and 23[1]. No changes to scrim. [0] https://img.bi/#/RfktdVg!bgYkhbeeajdlJaxCuKBcAE5mjnfrgseobpleaOtc [1] https://img.bi/#/7cnYA6V!JnreLCNwfkgertavWMcNaadRhzDSusebgIbtySrl Bug: T107338 Change-Id: Ib58c20fcca821fe1afe450cb2c8d0ffd60af4440 --- M app/src/main/java/org/wikipedia/page/PageActivity.java A app/src/main/res/drawable/drawer_shadow.xml 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia refs/changes/17/239517/1 diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java b/app/src/main/java/org/wikipedia/page/PageActivity.java index d51ec10..2399ad4 100644 --- a/app/src/main/java/org/wikipedia/page/PageActivity.java +++ b/app/src/main/java/org/wikipedia/page/PageActivity.java @@ -210,6 +210,7 @@ updateProgressBar(false, true, 0); drawerLayout = (WikiDrawerLayout) findViewById(R.id.drawer_layout); + drawerLayout.setDrawerShadow(R.drawable.drawer_shadow, GravityCompat.START); navDrawer = (NavigationView) findViewById(R.id.navdrawer); navMenu = navDrawer.getMenu(); navDrawerHelper = new NavDrawerHelper(this); diff --git a/app/src/main/res/drawable/drawer_shadow.xml b/app/src/main/res/drawable/drawer_shadow.xml new file mode 100644 index 0000000..e0464ed --- /dev/null +++ b/app/src/main/res/drawable/drawer_shadow.xml @@ -0,0 +1,8 @@ +<?xml version="1.0" encoding="utf-8"?> +<shape xmlns:android="http://schemas.android.com/apk/res/android";> + <gradient android:startColor="#30000000" + android:endColor="@android:color/transparent" + android:angle="0" /> + + <size android:width="16dp" /> +</shape> \ No newline at end of file -- To view, visit https://gerrit.wikimedia.org/r/239517 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib58c20fcca821fe1afe450cb2c8d0ffd60af4440 Gerrit-PatchSet: 1 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Niedzielski <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
