Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/251835
Change subject: ve.ui.Sequence: Allow sequences to insert content
......................................................................
ve.ui.Sequence: Allow sequences to insert content
Previously it would be accidentally immediately deleted when we called
`stripFragment.removeContent()` a few lines later.
Example sequence that only works correctly with this patch:
I6be5fb2118cf3eef5098d4c5320228aa81411ccb.
Change-Id: I14cd7efac521687ea38580341ae08ddc522edeeb
---
M src/ui/ve.ui.Sequence.js
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/35/251835/1
diff --git a/src/ui/ve.ui.Sequence.js b/src/ui/ve.ui.Sequence.js
index a4b5d93..4406066 100644
--- a/src/ui/ve.ui.Sequence.js
+++ b/src/ui/ve.ui.Sequence.js
@@ -76,7 +76,11 @@
if ( this.strip ) {
stripRange = surfaceModel.getSelection().getRange();
- stripFragment = surfaceModel.getLinearFragment( new ve.Range(
stripRange.end, stripRange.end - this.strip ) );
+ stripFragment = surfaceModel.getLinearFragment(
+ new ve.Range( stripRange.end, stripRange.end -
this.strip ),
+ /* noAutoSelect */ true,
+ /* excludeInsertions */ true
+ );
}
surfaceModel.breakpoint();
--
To view, visit https://gerrit.wikimedia.org/r/251835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14cd7efac521687ea38580341ae08ddc522edeeb
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
