jenkins-bot has submitted this change and it was merged.
Change subject: ve.ui.Sequence: Allow sequences to insert content
......................................................................
ve.ui.Sequence: Allow sequences to insert content
Previously it would be accidentally immediately deleted when we called
`stripFragment.removeContent()` a few lines later.
Example sequence that only works correctly with this patch:
I6be5fb2118cf3eef5098d4c5320228aa81411ccb.
Change-Id: I14cd7efac521687ea38580341ae08ddc522edeeb
---
M src/ui/ve.ui.Sequence.js
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/ve.ui.Sequence.js b/src/ui/ve.ui.Sequence.js
index a4b5d93..367a7d2 100644
--- a/src/ui/ve.ui.Sequence.js
+++ b/src/ui/ve.ui.Sequence.js
@@ -76,7 +76,10 @@
if ( this.strip ) {
stripRange = surfaceModel.getSelection().getRange();
- stripFragment = surfaceModel.getLinearFragment( new ve.Range(
stripRange.end, stripRange.end - this.strip ) );
+ stripFragment = surfaceModel.getLinearFragment(
+ // noAutoSelect = true, excludeInsertions = true
+ new ve.Range( stripRange.end, stripRange.end -
this.strip ), true, true
+ );
}
surfaceModel.breakpoint();
--
To view, visit https://gerrit.wikimedia.org/r/251835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14cd7efac521687ea38580341ae08ddc522edeeb
Gerrit-PatchSet: 4
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
