jenkins-bot has submitted this change and it was merged. Change subject: Code style cleanups to notifyOnPageChange() ......................................................................
Code style cleanups to notifyOnPageChange() Change-Id: I08593be2eba6417cdfae31b1aa1021da7db00c74 --- M includes/mail/EmailNotification.php 1 file changed, 14 insertions(+), 15 deletions(-) Approvals: Addshore: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/mail/EmailNotification.php b/includes/mail/EmailNotification.php index e51b434..8bac6b8 100644 --- a/includes/mail/EmailNotification.php +++ b/includes/mail/EmailNotification.php @@ -166,22 +166,21 @@ } } - if ( !$sendEmail ) { - return; + if ( $sendEmail ) { + JobQueueGroup::singleton()->lazyPush( new EnotifNotifyJob( + $title, + array( + 'editor' => $editor->getName(), + 'editorID' => $editor->getID(), + 'timestamp' => $timestamp, + 'summary' => $summary, + 'minorEdit' => $minorEdit, + 'oldid' => $oldid, + 'watchers' => $watchers, + 'pageStatus' => $pageStatus + ) + ) ); } - - $params = array( - 'editor' => $editor->getName(), - 'editorID' => $editor->getID(), - 'timestamp' => $timestamp, - 'summary' => $summary, - 'minorEdit' => $minorEdit, - 'oldid' => $oldid, - 'watchers' => $watchers, - 'pageStatus' => $pageStatus - ); - $job = new EnotifNotifyJob( $title, $params ); - JobQueueGroup::singleton()->lazyPush( $job ); } /** -- To view, visit https://gerrit.wikimedia.org/r/267395 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08593be2eba6417cdfae31b1aa1021da7db00c74 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits