Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/271023
Change subject: JsonContent: Call member functions with '$this->', not 'self::'
......................................................................
JsonContent: Call member functions with '$this->', not 'self::'
Change-Id: I7dab69ff77c98439f90e7d79f31d0e9128728683
---
M includes/content/JsonContent.php
1 file changed, 8 insertions(+), 8 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/23/271023/1
diff --git a/includes/content/JsonContent.php b/includes/content/JsonContent.php
index bf3a25b..6ee61b9 100644
--- a/includes/content/JsonContent.php
+++ b/includes/content/JsonContent.php
@@ -121,19 +121,19 @@
*/
protected function rootValueTable( $val ) {
if ( is_object( $val ) ) {
- return self::objectTable( $val );
+ return $this->objectTable( $val );
}
if ( is_array( $val ) ) {
// Wrap arrays in another array so that they're
visually boxed in a container.
// Otherwise they are visually indistinguishable from a
single value.
- return self::arrayTable( array( $val ) );
+ return $this->arrayTable( array( $val ) );
}
return Html::rawElement( 'table', array( 'class' => 'mw-json
mw-json-single-value' ),
Html::rawElement( 'tbody', array(),
Html::rawElement( 'tr', array(),
- Html::element( 'td', array(),
self::primitiveValue( $val ) )
+ Html::element( 'td', array(),
$this->primitiveValue( $val ) )
)
)
);
@@ -174,7 +174,7 @@
*/
protected function objectRow( $key, $val ) {
$th = Html::element( 'th', array(), $key );
- $td = self::valueCell( $val );
+ $td = $this->valueCell( $val );
return Html::rawElement( 'tr', array(), $th . $td );
}
@@ -211,7 +211,7 @@
* @return string HTML.
*/
protected function arrayRow( $val ) {
- $td = self::valueCell( $val );
+ $td = $this->valueCell( $val );
return Html::rawElement( 'tr', array(), $td );
}
@@ -223,14 +223,14 @@
*/
protected function valueCell( $val ) {
if ( is_object( $val ) ) {
- return Html::rawElement( 'td', array(),
self::objectTable( $val ) );
+ return Html::rawElement( 'td', array(),
$this->objectTable( $val ) );
}
if ( is_array( $val ) ) {
- return Html::rawElement( 'td', array(),
self::arrayTable( $val ) );
+ return Html::rawElement( 'td', array(),
$this->arrayTable( $val ) );
}
- return Html::element( 'td', array( 'class' => 'value' ),
self::primitiveValue( $val ) );
+ return Html::element( 'td', array( 'class' => 'value' ),
$this->primitiveValue( $val ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/271023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dab69ff77c98439f90e7d79f31d0e9128728683
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
