jenkins-bot has submitted this change and it was merged.
Change subject: JsonContent: Call member functions with '$this->', not 'self::'
......................................................................
JsonContent: Call member functions with '$this->', not 'self::'
Change-Id: I7dab69ff77c98439f90e7d79f31d0e9128728683
---
M includes/content/JsonContent.php
1 file changed, 8 insertions(+), 8 deletions(-)
Approvals:
Daniel Kinzler: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/content/JsonContent.php b/includes/content/JsonContent.php
index 8fe88fe..b9215fc 100644
--- a/includes/content/JsonContent.php
+++ b/includes/content/JsonContent.php
@@ -121,19 +121,19 @@
*/
protected function rootValueTable( $val ) {
if ( is_object( $val ) ) {
- return self::objectTable( $val );
+ return $this->objectTable( $val );
}
if ( is_array( $val ) ) {
// Wrap arrays in another array so that they're
visually boxed in a container.
// Otherwise they are visually indistinguishable from a
single value.
- return self::arrayTable( [ $val ] );
+ return $this->arrayTable( [ $val ] );
}
return Html::rawElement( 'table', [ 'class' => 'mw-json
mw-json-single-value' ],
Html::rawElement( 'tbody', [],
Html::rawElement( 'tr', [],
- Html::element( 'td', [],
self::primitiveValue( $val ) )
+ Html::element( 'td', [],
$this->primitiveValue( $val ) )
)
)
);
@@ -174,7 +174,7 @@
*/
protected function objectRow( $key, $val ) {
$th = Html::element( 'th', [], $key );
- $td = self::valueCell( $val );
+ $td = $this->valueCell( $val );
return Html::rawElement( 'tr', [], $th . $td );
}
@@ -211,7 +211,7 @@
* @return string HTML.
*/
protected function arrayRow( $val ) {
- $td = self::valueCell( $val );
+ $td = $this->valueCell( $val );
return Html::rawElement( 'tr', [], $td );
}
@@ -223,14 +223,14 @@
*/
protected function valueCell( $val ) {
if ( is_object( $val ) ) {
- return Html::rawElement( 'td', [], self::objectTable(
$val ) );
+ return Html::rawElement( 'td', [], $this->objectTable(
$val ) );
}
if ( is_array( $val ) ) {
- return Html::rawElement( 'td', [], self::arrayTable(
$val ) );
+ return Html::rawElement( 'td', [], $this->arrayTable(
$val ) );
}
- return Html::element( 'td', [ 'class' => 'value' ],
self::primitiveValue( $val ) );
+ return Html::element( 'td', [ 'class' => 'value' ],
$this->primitiveValue( $val ) );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/271023
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dab69ff77c98439f90e7d79f31d0e9128728683
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Kaldari <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
