Zfilipin has uploaded a new change for review. https://gerrit.wikimedia.org/r/271778
Change subject: Cleanup Cucumber tags in Selenium tests ...................................................................... Cleanup Cucumber tags in Selenium tests Removing no longer used @clean and @login tags. Bug: T127423 Change-Id: Id6f1abfae63b35b7e01dc9d58450a52a35d7c9df --- M tests/browser/features/autonym.feature M tests/browser/features/font_selection_default_disabled.feature M tests/browser/features/font_selection_default_enabled.feature M tests/browser/features/ime.feature M tests/browser/features/live_preview_of_display_language.feature M tests/browser/features/persistent_settings.feature M tests/browser/features/settings_panel.feature M tests/browser/features/textarea_font.feature M tests/browser/features/triggers.feature M tests/browser/tags.txt 10 files changed, 10 insertions(+), 26 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/78/271778/1 diff --git a/tests/browser/features/autonym.feature b/tests/browser/features/autonym.feature index be37933..0253062 100644 --- a/tests/browser/features/autonym.feature +++ b/tests/browser/features/autonym.feature @@ -4,7 +4,6 @@ * With tofu detection in ULS, system fonts will be given preference over webfonts. * Reference: https://upload.wikimedia.org/wikipedia/commons/7/7d/ULS-WebFonts-Workflow-Diagram.png - @login Scenario: Autonym font is used in the ULS language search dialog for display language selection by logged-in users Given I am logged in And I open the Universal Language Selector @@ -12,7 +11,6 @@ When I click the button with the ellipsis Then the language list of ULS should use Autonym font - @login Scenario: Autonym font is used in the ULS language search dialog for input language selection by logged-in users Given I am logged in And I open the Universal Language Selector diff --git a/tests/browser/features/font_selection_default_disabled.feature b/tests/browser/features/font_selection_default_disabled.feature index d7124c0..9e0cfab 100644 --- a/tests/browser/features/font_selection_default_disabled.feature +++ b/tests/browser/features/font_selection_default_disabled.feature @@ -1,4 +1,4 @@ -@firefox @internet_explorer_10 @login @phantomjs +@firefox @internet_explorer_10 @phantomjs Feature: Font selection default disabled In order to have better using experience, diff --git a/tests/browser/features/font_selection_default_enabled.feature b/tests/browser/features/font_selection_default_enabled.feature index 89007db..eb4418a 100644 --- a/tests/browser/features/font_selection_default_enabled.feature +++ b/tests/browser/features/font_selection_default_enabled.feature @@ -1,4 +1,4 @@ -@firefox @internet_explorer_10 @language-browsertests.wmflabs.org @login @phantomjs +@firefox @internet_explorer_10 @language-browsertests.wmflabs.org @phantomjs Feature: Font selection default enabled In order to have better using experience, diff --git a/tests/browser/features/ime.feature b/tests/browser/features/ime.feature index fa8bfcb..f869f80 100644 --- a/tests/browser/features/ime.feature +++ b/tests/browser/features/ime.feature @@ -6,7 +6,7 @@ method in different input fields and temporarily activate and deactivate the input method. - @clean @commons.wikimedia.beta.wmflabs.org @internet_explorer_10 + @commons.wikimedia.beta.wmflabs.org @internet_explorer_10 Scenario: Input method indicator is shown The input method indicator is shown when input field gets a focus. @@ -54,7 +54,7 @@ Then I should see the input method indicator And in it there must be an element with Malayalam text - @clean @commons.wikimedia.beta.wmflabs.org @internet_explorer_10 + @commons.wikimedia.beta.wmflabs.org @internet_explorer_10 Scenario Outline: Input method menu is completely visible Given I visit a random page with <skin> skin and <language> as the interface language When I open the input method menu diff --git a/tests/browser/features/live_preview_of_display_language.feature b/tests/browser/features/live_preview_of_display_language.feature index b410681..2fe8046 100644 --- a/tests/browser/features/live_preview_of_display_language.feature +++ b/tests/browser/features/live_preview_of_display_language.feature @@ -1,4 +1,4 @@ -@firefox @internet_explorer_10 @login @phantomjs +@firefox @internet_explorer_10 @phantomjs Feature: Live preview of display language changes Background: @@ -14,7 +14,6 @@ And I click on the link to select Malayalam Then I should see the text in the language panel in Malayalam - @clean Scenario: Live preview of display language changes can be reverted on cancel Given I open the Universal Language Selector And I open Display panel of language settings @@ -23,7 +22,6 @@ And I open Display panel of language settings Then I should see the text in the language panel in English - @clean Scenario: Live preview of display language changes can be reverted on closing the dialog with the X button Given I open the Universal Language Selector And I open Display panel of language settings @@ -33,7 +31,7 @@ Then I should see the text in the language panel in English # https://phabricator.wikimedia.org/T59967 - # @clean @commons.wikimedia.beta.wmflabs.org + # @commons.wikimedia.beta.wmflabs.org Scenario: Live preview of display language changes can be reverted on closing the dialog on cancel from a different panel Given I open the Universal Language Selector And I open Display panel of language settings diff --git a/tests/browser/features/persistent_settings.feature b/tests/browser/features/persistent_settings.feature index b3dac0f..1960647 100644 --- a/tests/browser/features/persistent_settings.feature +++ b/tests/browser/features/persistent_settings.feature @@ -1,5 +1,5 @@ # First scenario seems to fail whenever OpenDyslexic is missing -@firefox @internet_explorer_10 @login @phantomjs +@firefox @internet_explorer_10 @phantomjs Feature: Persistent settings This assumes wiki content language is English. diff --git a/tests/browser/features/settings_panel.feature b/tests/browser/features/settings_panel.feature index 7dd1941..c4ff97d 100644 --- a/tests/browser/features/settings_panel.feature +++ b/tests/browser/features/settings_panel.feature @@ -1,7 +1,7 @@ @firefox @internet_explorer_10 @phantomjs Feature: Settings panel - @login @ime-default-on + @ime-default-on Scenario Outline: Input settings display Given I am <user status> And I am on a page without interlanguage links @@ -33,7 +33,6 @@ And I see Language Search And I can navigate back to Input Settings - @login Scenario: More languages (interface language selection) Given I am logged in When I open Language panel of language settings @@ -43,7 +42,6 @@ And I see Language Search And I can navigate back to Language Settings - @login Scenario: Temporary live preview for menu language Given I am logged in @@ -67,7 +65,6 @@ When I open Language panel of language settings Then I see "English (sama kuin sisällön)" as the name of the content language - @login Scenario: Selecting language via [...] button Given I am logged in @@ -78,7 +75,6 @@ And I apply the changes Then my interface language is "German" - @login Scenario: Regression test for bug T58913 Given I am logged in diff --git a/tests/browser/features/textarea_font.feature b/tests/browser/features/textarea_font.feature index 410c26f..0a5c4d5 100644 --- a/tests/browser/features/textarea_font.feature +++ b/tests/browser/features/textarea_font.feature @@ -1,4 +1,4 @@ -@firefox @internet_explorer_10 @login @phantomjs +@firefox @internet_explorer_10 @phantomjs Feature: Font preferences respected in different languages If a user has an edit font preferences respect that preference. @@ -11,7 +11,6 @@ Given I am logged in And I have reset my preferences - @clean Scenario: Edit area fonts should not change on UI language change if the user preferences for edit area font are set When I set the editing fonts to "monospace" And I set "Hindi" as the interface language diff --git a/tests/browser/features/triggers.feature b/tests/browser/features/triggers.feature index 9ec4c01..ffd45db 100644 --- a/tests/browser/features/triggers.feature +++ b/tests/browser/features/triggers.feature @@ -1,7 +1,7 @@ @firefox @internet_explorer_10 @phantomjs Feature: Trigger in personal toolbar - @commons.wikimedia.beta.wmflabs.org @login + @commons.wikimedia.beta.wmflabs.org Scenario: Open language selector when logged in Given I am logged in When I click language selector trigger element @@ -25,8 +25,6 @@ When I click language selector trigger element Then I should see the language selector - - @login Scenario Outline: Opening language settings from sidebar Given I am <user status> And I am on <page type> @@ -40,7 +38,6 @@ | logged out | a talk page without interlanguage links | | logged out | a talk page with interlanguage links | - @login Scenario Outline: Closing language settings without saving Given I am <user status> And I am on a page without interlanguage links diff --git a/tests/browser/tags.txt b/tests/browser/tags.txt index 997068a..7b1bf9a 100644 --- a/tests/browser/tags.txt +++ b/tests/browser/tags.txt @@ -10,7 +10,3 @@ @ime-default-on These tests expect input methods to be enabled by default. - -@login - This test logs in. You can filter these tests out if you don't have an - account available. -- To view, visit https://gerrit.wikimedia.org/r/271778 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id6f1abfae63b35b7e01dc9d58450a52a35d7c9df Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Zfilipin <zfili...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
