Ori.livneh has submitted this change and it was merged. Change subject: Remove RejectParserCacheValue hook handler ......................................................................
Remove RejectParserCacheValue hook handler The string pattern that the currently-deployed code is searching for is no longer occurring, and the new code runs the risk of masking the problem without fixing it. Change-Id: I19defe45283c4a23d9431fe91a34ae7c32067d4b --- M extension.json M includes/MobileFrontend.hooks.php 2 files changed, 0 insertions(+), 20 deletions(-) Approvals: Ori.livneh: Verified; Looks good to me, approved diff --git a/extension.json b/extension.json index 167e5fc..9aed26a 100644 --- a/extension.json +++ b/extension.json @@ -1961,9 +1961,6 @@ ], "TitleSquidURLs": [ "MobileFrontendHooks::onTitleSquidURLs" - ], - "RejectParserCacheValue": [ - "MobileFrontendHooks::onRejectParserCacheValue" ] }, "config": { diff --git a/includes/MobileFrontend.hooks.php b/includes/MobileFrontend.hooks.php index 856e4f3..5b7415d 100644 --- a/includes/MobileFrontend.hooks.php +++ b/includes/MobileFrontend.hooks.php @@ -1308,23 +1308,6 @@ } /** - * Remove corruption caused by T124356 from the parser cache - * - * @param ParserOutput $value - * @param WikiPage $wikiPage - * @param ParserOptions $popts - * @return bool - */ - public static function onRejectParserCacheValue( $value, $wikiPage, $popts ) { - if ( strpos( $value->getRawText(), '<a href="#/editor/' ) !== false ) { - // Bug T124356 parser cache corruption - return false; - } - - return true; - } - - /** * Handler for Extension registration callback */ public static function onRegistration() { -- To view, visit https://gerrit.wikimedia.org/r/273503 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I19defe45283c4a23d9431fe91a34ae7c32067d4b Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: wmf/1.27.0-wmf.14 Gerrit-Owner: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits