jenkins-bot has submitted this change and it was merged.

Change subject: Remove RejectParserCacheValue hook handler
......................................................................


Remove RejectParserCacheValue hook handler

The string pattern that the currently-deployed code is searching for is no
longer occurring, and the new code runs the risk of masking the problem without
fixing it.

Change-Id: I19defe45283c4a23d9431fe91a34ae7c32067d4b
---
M extension.json
M includes/MobileFrontend.hooks.php
2 files changed, 0 insertions(+), 21 deletions(-)

Approvals:
  Jdlrobson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index fd7e954..cfbcf6f 100644
--- a/extension.json
+++ b/extension.json
@@ -1961,9 +1961,6 @@
                ],
                "TitleSquidURLs": [
                        "MobileFrontendHooks::onTitleSquidURLs"
-               ],
-               "RejectParserCacheValue": [
-                       "MobileFrontendHooks::onRejectParserCacheValue"
                ]
        },
        "config": {
diff --git a/includes/MobileFrontend.hooks.php 
b/includes/MobileFrontend.hooks.php
index f93958b..7e72b4c 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1333,24 +1333,6 @@
        }
 
        /**
-        * Remove corruption caused by T124356 from the parser cache
-        *
-        * @param ParserOutput $value
-        * @param WikiPage $wikiPage
-        * @param ParserOptions $popts
-        * @return bool
-        */
-       public static function onRejectParserCacheValue( $value, $wikiPage, 
$popts ) {
-               if ( strpos( $value->getRawText(), 'edit-page' ) !== false ) {
-                       // Bug T124356 parser cache corruption
-                       RequestContext::getMain()->getStats()->increment( 
'T124356' );
-                       return false;
-               }
-
-               return true;
-       }
-
-       /**
         * Handler for Extension registration callback
         */
        public static function onRegistration() {

-- 
To view, visit https://gerrit.wikimedia.org/r/273501
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I19defe45283c4a23d9431fe91a34ae7c32067d4b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to