jenkins-bot has submitted this change and it was merged.
Change subject: Move option sync from app to PageActivite.onCreate
......................................................................
Move option sync from app to PageActivite.onCreate
Synchronization of user options should occur at least as often as the
page Activity is created. Move synchronization from
WikipediaApp.onCreate to PageActivity.onCreate.
Change-Id: I2812e7150cfa039cd1f4eaa53753c75e17ae3e59
---
M app/src/main/java/org/wikipedia/WikipediaApp.java
M app/src/main/java/org/wikipedia/page/PageActivity.java
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/WikipediaApp.java
b/app/src/main/java/org/wikipedia/WikipediaApp.java
index 099761f..7014bbd 100644
--- a/app/src/main/java/org/wikipedia/WikipediaApp.java
+++ b/app/src/main/java/org/wikipedia/WikipediaApp.java
@@ -188,7 +188,6 @@
// TODO: remove this code after all logged in users also have a system
account or August 2016.
AccountUtil.createAccountForLoggedInUser();
- UserOptionContentResolver.requestManualSync();
UserOptionContentResolver.registerAppSyncObserver(this);
}
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index 5230a2f..4753d28 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -27,6 +27,7 @@
import org.wikipedia.staticdata.MainPageNameData;
import org.wikipedia.theme.ThemeChooserDialog;
import org.wikipedia.tooltip.ToolTipUtil;
+import org.wikipedia.useroption.sync.UserOptionContentResolver;
import org.wikipedia.util.ApiUtil;
import org.wikipedia.util.FeedbackUtil;
import org.wikipedia.util.log.L;
@@ -277,6 +278,8 @@
// Conditionally execute all recurring tasks
new RecurringTasksExecutor(app).run();
+
+ UserOptionContentResolver.requestManualSync();
}
private void finishActionMode() {
--
To view, visit https://gerrit.wikimedia.org/r/275594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2812e7150cfa039cd1f4eaa53753c75e17ae3e59
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>
Gerrit-Reviewer: BearND <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
