jenkins-bot has submitted this change and it was merged.
Change subject: Pass extension.json schema validation
......................................................................
Pass extension.json schema validation
extension.json only removes top level and "config" keys that start with
@, so this comment was actually being passed onto ResourceLoader and
eventually being ignored at that stage.
But since it's not a recognized value, it causes validation of the
extension.json file against the schema to fail.
Bug: T120508
Change-Id: Ibed94e1818c8fc9c3afdc3e09d0af5e84c49a342
---
M extension.json
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 55a90f3..2b38c02 100644
--- a/extension.json
+++ b/extension.json
@@ -94,6 +94,7 @@
"Gather\\api\\ApiQueryListMembership":
"includes/api/ApiQueryListMembership.php",
"Gather\\api\\ApiQueryListPages":
"includes/api/ApiQueryListPages.php"
},
+ "@doc": "FIXME: ext.gather.styles gets loaded twice. See
https://phabricator.wikimedia.org/T87871";,
"ResourceModules": {
"ext.gather.toastpanel": {
"targets": [
@@ -444,7 +445,6 @@
"mobile",
"desktop"
],
- "@doc": "FIXME: ext.gather.styles gets loaded twice.
See https://phabricator.wikimedia.org/T87871";,
"dependencies": [
"ext.gather.page.search",
"ext.gather.relatedpages",
--
To view, visit https://gerrit.wikimedia.org/r/273753
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibed94e1818c8fc9c3afdc3e09d0af5e84c49a342
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/Gather
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Florianschmidtwelzow <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
