jenkins-bot has submitted this change and it was merged.
Change subject: qunit: Don't require expect() anymore
......................................................................
qunit: Don't require expect() anymore
This hasn't been useful in QUnit for a while now with the improved
assertion context object and tracking of asynchronous tests without
shared global state.
Currently breaking REL1_26 because Wikibase is naughty.
Change-Id: Icaf865b4d6e85e739bf79c4d1bacb8a71ec5a3da
---
M tests/qunit/data/testrunner.js
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/qunit/data/testrunner.js b/tests/qunit/data/testrunner.js
index 01f9625..53bff76 100644
--- a/tests/qunit/data/testrunner.js
+++ b/tests/qunit/data/testrunner.js
@@ -27,8 +27,6 @@
// and assuming failure.
QUnit.config.testTimeout = 30 * 1000;
- QUnit.config.requireExpects = true;
-
// Add a checkbox to QUnit header to toggle MediaWiki ResourceLoader
debug mode.
QUnit.config.urlConfig.push( {
id: 'debug',
--
To view, visit https://gerrit.wikimedia.org/r/274878
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icaf865b4d6e85e739bf79c4d1bacb8a71ec5a3da
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_26
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
