Awight has uploaded a new change for review.
https://gerrit.wikimedia.org/r/281581
Change subject: Trim email during normalization
......................................................................
Trim email during normalization
Trailing spaces would cause validation failure, which is silly and confusing.
On a hunch that mobile devices like to add extra spaces, I'm hoping this will
close:
Bug: T131323
Change-Id: I25c38c59a2b9c7c358e5cd19dfbf4923cdf9099f
---
M gateway_common/DonationData.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DonationInterface
refs/changes/81/281581/1
diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index b426952..b082bf5 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -661,7 +661,9 @@
$email = $this->getVal( 'email' );
}
- $this->setVal( 'email', $email );
+ // Also trim whitespace
+ $this->setVal( 'email', trim( $email ) );
+
$this->expunge( 'emailAdd' );
}
--
To view, visit https://gerrit.wikimedia.org/r/281581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25c38c59a2b9c7c358e5cd19dfbf4923cdf9099f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
