jenkins-bot has submitted this change and it was merged.
Change subject: Trim email during normalization
......................................................................
Trim email during normalization
Trailing spaces would cause validation failure, which is silly and confusing.
On a hunch that mobile devices like to add extra spaces, I'm hoping this will
close:
Bug: T131323
Change-Id: I25c38c59a2b9c7c358e5cd19dfbf4923cdf9099f
---
M gateway_common/DonationData.php
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Ejegg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_common/DonationData.php b/gateway_common/DonationData.php
index b426952..ec4f02e 100644
--- a/gateway_common/DonationData.php
+++ b/gateway_common/DonationData.php
@@ -661,6 +661,11 @@
$email = $this->getVal( 'email' );
}
+ // Also trim whitespace
+ if ( $email ) {
+ $email = trim( $email );
+ }
+
$this->setVal( 'email', $email );
$this->expunge( 'emailAdd' );
}
--
To view, visit https://gerrit.wikimedia.org/r/281581
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I25c38c59a2b9c7c358e5cd19dfbf4923cdf9099f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Ssmith <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
