Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/282990
Change subject: Revert "Measure commitMasterChanges() run time"
......................................................................
Revert "Measure commitMasterChanges() run time"
This reverts commit efb441883937. This is the biggest metric
by statsd traffic volume on the Wikimedia cluster. Please re-introduce
this only with sampling.
Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea
---
M includes/db/loadbalancer/LBFactory.php
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/90/282990/1
diff --git a/includes/db/loadbalancer/LBFactory.php
b/includes/db/loadbalancer/LBFactory.php
index 86f0110..e7b7627 100644
--- a/includes/db/loadbalancer/LBFactory.php
+++ b/includes/db/loadbalancer/LBFactory.php
@@ -200,10 +200,7 @@
* Commit changes on all master connections
*/
public function commitMasterChanges() {
- $start = microtime( true );
$this->forEachLBCallMethod( 'commitMasterChanges' );
- $timeMs = 1000 * ( microtime( true ) - $start );
- RequestContext::getMain()->getStats()->timing(
"db.commit-masters", $timeMs );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/282990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
