Ori.livneh has submitted this change and it was merged.
Change subject: Revert "Measure commitMasterChanges() run time"
......................................................................
Revert "Measure commitMasterChanges() run time"
This reverts commit efb441883937. This is the biggest metric
by statsd traffic volume on the Wikimedia cluster. Please re-introduce this
only with sampling.
Bug: T101141
Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea
---
M includes/db/loadbalancer/LBFactory.php
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
Ori.livneh: Verified; Looks good to me, approved
diff --git a/includes/db/loadbalancer/LBFactory.php
b/includes/db/loadbalancer/LBFactory.php
index a484bb44..f39596b 100644
--- a/includes/db/loadbalancer/LBFactory.php
+++ b/includes/db/loadbalancer/LBFactory.php
@@ -247,11 +247,7 @@
} );
} );
- $start = microtime( true );
$this->forEachLBCallMethod( 'commitMasterChanges', [ $fname ] );
- $timeMs = 1000 * ( microtime( true ) - $start );
-
- RequestContext::getMain()->getStats()->timing(
"db.commit-masters", $timeMs );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/283000
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc3b3aaa98dcefe1a80a4f458a83232c29a27ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: wmf/1.27.0-wmf.21
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
