Phuedx has uploaded a new change for review.
https://gerrit.wikimedia.org/r/284873
Change subject: Add missing mw.popups.selectPopupElements test case
......................................................................
Add missing mw.popups.selectPopupElements test case
Follow up on Id173b21 by adding a test case that covers the test of
whether the anchor's title is in a content namespace.
Bug: T129693
Change-Id: I414a5ff8aa4edf58dd0d1947db077afdd1d22f39
---
M tests/qunit/ext.popups.core.test.js
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups
refs/changes/73/284873/1
diff --git a/tests/qunit/ext.popups.core.test.js
b/tests/qunit/ext.popups.core.test.js
index ca630ea..b84cc7e 100644
--- a/tests/qunit/ext.popups.core.test.js
+++ b/tests/qunit/ext.popups.core.test.js
@@ -113,6 +113,13 @@
href: '/wiki/Popups'
} ).appendTo( mw.popups.$content );
+ // Add a link that's not in a content namespace.
+ $( '<a>', {
+ text: 'link with tooltip',
+ title: 'foo.jpg',
+ href: '/wiki/File:foo.jpg'
+ } ).appendTo( mw.popups.$content );
+
// only the last link above should be selected for having a
hover card
assert.equal(
mw.popups.selectPopupElements().length,
--
To view, visit https://gerrit.wikimedia.org/r/284873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I414a5ff8aa4edf58dd0d1947db077afdd1d22f39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
