jenkins-bot has submitted this change and it was merged.

Change subject: Add missing mw.popups.selectPopupElements test case
......................................................................


Add missing mw.popups.selectPopupElements test case

Follow up on Id173b21 by adding a test case that covers the test of
whether the anchor's title is in a content namespace.

Bug: T133020
Change-Id: I414a5ff8aa4edf58dd0d1947db077afdd1d22f39
---
M tests/qunit/ext.popups.core.test.js
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Bmansurov: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tests/qunit/ext.popups.core.test.js 
b/tests/qunit/ext.popups.core.test.js
index ca630ea..c99e860 100644
--- a/tests/qunit/ext.popups.core.test.js
+++ b/tests/qunit/ext.popups.core.test.js
@@ -106,6 +106,13 @@
                        title: 'link title'
                } ).appendTo( mw.popups.$content );
 
+               // Add a link that's not in a content namespace.
+               $( '<a>', {
+                       text: 'link with tooltip',
+                       title: 'foo.jpg',
+                       href: '/wiki/File:foo.jpg'
+               } ).appendTo( mw.popups.$content );
+
                // add a link that will have a hover card
                $( '<a>', {
                        text: 'link with tooltip',

-- 
To view, visit https://gerrit.wikimedia.org/r/284873
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I414a5ff8aa4edf58dd0d1947db077afdd1d22f39
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Popups
Gerrit-Branch: master
Gerrit-Owner: Phuedx <[email protected]>
Gerrit-Reviewer: Bmansurov <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to