jenkins-bot has submitted this change and it was merged.
Change subject: styles: Factor out `max-width-input-default` variable
......................................................................
styles: Factor out `max-width-input-default` variable
Introducing `max-width` Less variable on various input widgets.
Change-Id: I9050e1ab5be75028c1ef9be777d785e332296d88
---
M src/themes/apex/common.less
M src/themes/apex/widgets.less
M src/themes/mediawiki/common.less
M src/themes/mediawiki/widgets.less
4 files changed, 23 insertions(+), 17 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/apex/common.less b/src/themes/apex/common.less
index 03253e1..81237ca 100644
--- a/src/themes/apex/common.less
+++ b/src/themes/apex/common.less
@@ -17,6 +17,9 @@
@oo-ui-default-image-path: 'themes/apex/images';
+// Box Sizes
+@max-width-input-default: 50em;
+
@size-icon-min: 24px;
@size-indicator-min: 12px;
@size-icon: unit(24 / 16 / 0.8, em);
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 13b01af..9f901fc 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -100,7 +100,7 @@
.theme-oo-ui-dropdownWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
background-color: @background-color-main;
.oo-ui-inline-spacing(0.5em);
@@ -165,7 +165,7 @@
.theme-oo-ui-selectFileWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
.oo-ui-inline-spacing(0.5em);
@@ -331,7 +331,7 @@
.theme-oo-ui-dropdownInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
select {
background-color: @background-color-main;
@@ -377,7 +377,7 @@
.theme-oo-ui-textInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
input,
textarea {
@@ -481,7 +481,7 @@
.theme-oo-ui-comboBoxInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
.oo-ui-inline-spacing(0.5em);
@@ -498,7 +498,7 @@
.theme-oo-ui-capsuleMultiSelectWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
&-handle {
background-color: @background-color-main;
@@ -937,7 +937,7 @@
}
.theme-oo-ui-numberInputWidget () {
- max-width: 50em;
+ max-width: @max-width-input-default;
&-field > .oo-ui-buttonWidget {
width: 2.25em;
@@ -1028,7 +1028,7 @@
}
.theme-oo-ui-progressBarWidget () {
- max-width: 50em;
+ max-width: @max-width-input-default;
background-color: @background-color-main;
border: 1px solid #ccc;
border-radius: 0.25em;
diff --git a/src/themes/mediawiki/common.less b/src/themes/mediawiki/common.less
index 4eb51a6..07e107e 100644
--- a/src/themes/mediawiki/common.less
+++ b/src/themes/mediawiki/common.less
@@ -34,6 +34,10 @@
// Invalid Widget (validation error feedback)
@color-invalid: #f00;
+
+// Box Sizes
+@max-width-input-default: 50em;
+
@size-icon-min: 24px;
@size-indicator-min: 12px;
@size-icon: unit( 24 / 16 / 0.8, em );
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index 351e2bd..66d2cee 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -97,9 +97,8 @@
.theme-oo-ui-dropdownWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
background-color: @background-color-default;
-
.oo-ui-inline-spacing( 0.5em );
&-handle {
@@ -163,7 +162,7 @@
.theme-oo-ui-selectFileWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
.oo-ui-inline-spacing( 0.5em );
@@ -414,7 +413,7 @@
.theme-oo-ui-dropdownInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
select {
background-color: @background-color-default;
@@ -551,7 +550,7 @@
.theme-oo-ui-textInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
input,
textarea {
@@ -679,7 +678,7 @@
.theme-oo-ui-comboBoxInputWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
.oo-ui-inline-spacing( 0.5em );
@@ -691,7 +690,7 @@
.theme-oo-ui-capsuleMultiSelectWidget () {
width: 100%;
- max-width: 50em;
+ max-width: @max-width-input-default;
&-handle {
background-color: @background-color-default;
@@ -1130,7 +1129,7 @@
}
.theme-oo-ui-numberInputWidget () {
- max-width: 50em;
+ max-width: @max-width-input-default;
&-field > .oo-ui-buttonWidget {
width: 2.5em;
@@ -1264,7 +1263,7 @@
}
.theme-oo-ui-progressBarWidget () {
- max-width: 50em;
+ max-width: @max-width-input-default;
background-color: @background-color-default;
border: @border-default;
border-radius: @border-radius-default;
--
To view, visit https://gerrit.wikimedia.org/r/283690
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9050e1ab5be75028c1ef9be777d785e332296d88
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: VolkerE <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
