TheDJ has uploaded a new change for review. https://gerrit.wikimedia.org/r/288249
Change subject: Remove fallback content of video/audio tag ...................................................................... Remove fallback content of video/audio tag These html5 elements have been provided for a long time now. Most browsers will never see this content, yet it adds quite a few bytes. The message is also no longer correct, since lack of JS will also not show you this content. Bug: T133671 Change-Id: I63f57f6875235221e1ef2c002debbb9527762f31 --- M TimedMediaTransformOutput.php M i18n/en.json M i18n/qqq.json 3 files changed, 1 insertion(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler refs/changes/49/288249/1 diff --git a/TimedMediaTransformOutput.php b/TimedMediaTransformOutput.php index 37d6658..24c1f05 100644 --- a/TimedMediaTransformOutput.php +++ b/TimedMediaTransformOutput.php @@ -342,11 +342,7 @@ // Timed text: self::htmlTagSet( 'track', - $this->file ? $this->getTextHandler()->getTracks() : null ) . - - // Fallback text displayed for browsers without js and without video tag support: - /// XXX note we may want to replace this with an image and download link play button - wfMessage( 'timedmedia-no-player-js', $firstSource['src'] )->text() + $this->file ? $this->getTextHandler()->getTracks() : null ); ); if ( $wgTmhWebPlayer === 'videojs' ) { diff --git a/i18n/en.json b/i18n/en.json index 70ec2bd..6d684d4 100644 --- a/i18n/en.json +++ b/i18n/en.json @@ -22,7 +22,6 @@ "timedmedia-wav-pcm-required": "You can only upload PCM (Pulse Code Modulation) WAV.", "timedmedia-mp4-short-video": "MP4 $1 video file, $2", "timedmedia-mp4-long-video": "MP4 audio/video file, $1, length $2, $4 × $5 pixels, $3 overall", - "timedmedia-no-player-js": "Sorry, your browser either has JavaScript disabled or does not have any supported player.<br />\nYou can <a href=\"$1\">download the clip</a> or <a href=\"https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download\">download a player</a> to play the clip in your browser.", "timedmedia-more": "More…", "timedmedia-dismiss": "Close", "timedmedia-download": "Download file", diff --git a/i18n/qqq.json b/i18n/qqq.json index 01f7187..5942d05 100644 --- a/i18n/qqq.json +++ b/i18n/qqq.json @@ -40,7 +40,6 @@ "timedmedia-wav-pcm-required": "Message shown at upload if user tries to upload a WAV file using a codec that is not PCM", "timedmedia-mp4-short-video": "File details for MP4 video files, short version.\nParameters:\n* $1 - stream type names (slash separated) - e.g. AAC/h.264\n* $2 - duration of the video (localized) - e.g. 1m34s\nSee also:\n* {{msg-mw|Timedmedia-mp4-long-video}}", "timedmedia-mp4-long-video": "File details for MP4 multiplexed audio/video files, long version.\n\nShown after the filename in the image description page.\n\nParameters:\n* $1 - stream type names (slash separated) - e.g. AAC/h.264\n* $2 - duration (localized) - e.g. 1m34s\n* $3 - bit-rate (localized) - e.g. 97kbps\n* $4 - width of the video (in pixels)\n* $5 - height of the video (in pixels)\nSee also:\n* {{msg-mw|Timedmedia-mp4-short-video}}", - "timedmedia-no-player-js": "Used as fallback text displayed for browsers without js and without video tag support.\n\nParameters:\n* $1 - media source URL", "timedmedia-more": "Unused at this time.\n{{Identical|More...}}", "timedmedia-dismiss": "Unused at this time.\n{{Identical|Close}}", "timedmedia-download": "Used as tooltip for the Download button.\n{{Identical|Download}}", -- To view, visit https://gerrit.wikimedia.org/r/288249 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I63f57f6875235221e1ef2c002debbb9527762f31 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/TimedMediaHandler Gerrit-Branch: master Gerrit-Owner: TheDJ <hartman.w...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits