[MediaWiki-commits] [Gerrit] Remove fallback content of video/audio tag - change (mediawiki...TimedMediaHandler)

jenkins-bot (Code Review) Fri, 13 May 2016 09:13:10 -0700

jenkins-bot has submitted this change and it was merged.

Change subject: Remove fallback content of video/audio tag
......................................................................



Remove fallback content of video/audio tag

These html5 elements have been provided for a long time now. Most
browsers will never see this content, yet it adds quite a few bytes.

The message is also no longer correct, since lack of JS will also not
show you this content.

Bug: T133671
Change-Id: I63f57f6875235221e1ef2c002debbb9527762f31
---
M TimedMediaTransformOutput.php
M i18n/en.json
M i18n/qqq.json
M tests/parserTests.txt
4 files changed, 11 insertions(+), 19 deletions(-)

Approvals:
  Brion VIBBER: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/TimedMediaTransformOutput.php b/TimedMediaTransformOutput.php
index 37d6658..cd5a6f9 100644
--- a/TimedMediaTransformOutput.php
+++ b/TimedMediaTransformOutput.php
@@ -342,11 +342,7 @@
 
                        // Timed text:
                        self::htmlTagSet( 'track',
-                               $this->file ? 
$this->getTextHandler()->getTracks() : null ) .
-
-                       // Fallback text displayed for browsers without js and 
without video tag support:
-                       /// XXX note we may want to replace this with an image 
and download link play button
-                       wfMessage( 'timedmedia-no-player-js', 
$firstSource['src'] )->text()
+                               $this->file ? 
$this->getTextHandler()->getTracks() : null )
                );
 
                if ( $wgTmhWebPlayer === 'videojs' ) {
diff --git a/i18n/en.json b/i18n/en.json
index 70ec2bd..6d684d4 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -22,7 +22,6 @@
        "timedmedia-wav-pcm-required": "You can only upload PCM (Pulse Code 
Modulation) WAV.",
        "timedmedia-mp4-short-video": "MP4 $1 video file, $2",
        "timedmedia-mp4-long-video": "MP4 audio/video file, $1, length $2, $4 × 
$5 pixels, $3 overall",
-       "timedmedia-no-player-js": "Sorry, your browser either has JavaScript 
disabled or does not have any supported player.<br />\nYou can <a 
href=\"$1\">download the clip</a> or <a 
href=\"https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download\";>download
 a player</a> to play the clip in your browser.",
        "timedmedia-more": "More…",
        "timedmedia-dismiss": "Close",
        "timedmedia-download": "Download file",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 01f7187..5942d05 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -40,7 +40,6 @@
        "timedmedia-wav-pcm-required": "Message shown at upload if user tries 
to upload a WAV file using a codec that is not PCM",
        "timedmedia-mp4-short-video": "File details for MP4 video files, short 
version.\nParameters:\n* $1 - stream type names (slash separated) - e.g. 
AAC/h.264\n* $2 - duration of the video (localized) - e.g. 1m34s\nSee also:\n* 
{{msg-mw|Timedmedia-mp4-long-video}}",
        "timedmedia-mp4-long-video": "File details for MP4 multiplexed 
audio/video files, long version.\n\nShown after the filename in the image 
description page.\n\nParameters:\n* $1 - stream type names (slash separated) - 
e.g. AAC/h.264\n* $2 - duration (localized) - e.g. 1m34s\n* $3 - bit-rate 
(localized) - e.g. 97kbps\n* $4 - width of the video (in pixels)\n* $5 - height 
of the video (in pixels)\nSee also:\n* {{msg-mw|Timedmedia-mp4-short-video}}",
-       "timedmedia-no-player-js": "Used as fallback text displayed for 
browsers without js and without video tag support.\n\nParameters:\n* $1 - media 
source URL",
        "timedmedia-more": "Unused at this time.\n{{Identical|More...}}",
        "timedmedia-dismiss": "Unused at this time.\n{{Identical|Close}}",
        "timedmedia-download": "Used as tooltip for the Download 
button.\n{{Identical|Download}}",
diff --git a/tests/parserTests.txt b/tests/parserTests.txt
index 2050125..3e83d4f 100644
--- a/tests/parserTests.txt
+++ b/tests/parserTests.txt
@@ -3,12 +3,11 @@
 !! wikitext
 [[File:Video.ogv]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_1" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_1" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! html+tidy
 <div class="mediaContainer" style="width:320px"><video id="mwe_player_0" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local">
-<source src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30" />Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br />
-You can <a href="http://example.com/images/0/00/Video.ogv";>download the 
clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<source src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30" /></video></div>
 !!end
 
 !! test
@@ -16,13 +15,12 @@
 !! wikitext
 [[File:Video.ogv|thumb]]
 !! html
-<div class="thumb tright"><div class="thumbinner" style="width:182px;"><div 
id="mwe_player_4" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_5&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>  <div class="thumbcaption"><div 
class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div></div></div></div>
+<div class="thumb tright"><div class="thumbinner" style="width:182px;"><div 
id="mwe_player_4" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_5&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; 
data-framerate=&quot;30&quot;/&gt;&lt;/video&gt;&lt;/div&gt;"><img 
alt="File:Video.ogv" style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>  <div class="thumbcaption"><div 
class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div></div></div></div>
 
 !! html+tidy
 <div class="thumb tright">
 <div class="thumbinner" style="width:182px;">
-<div id="mwe_player_2" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_3&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;
-You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg"; /><a 
href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>
+<div id="mwe_player_2" class="PopUpMediaTransform" style="width:180px;" 
videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_3&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; 
data-framerate=&quot;30&quot;/&gt;&lt;/video&gt;&lt;/div&gt;"><img 
alt="File:Video.ogv" style="width:180px;height:135px" 
src="http://example.com/images/thumb/0/00/Video.ogv/180px--Video.ogv.jpg"; /><a 
href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div>
 <div class="thumbcaption">
 <div class="magnify"><a href="/wiki/File:Video.ogv" class="internal" 
title="Enlarge"></a></div>
 </div>
@@ -37,7 +35,7 @@
 !! html
 <ul class="gallery mw-gallery-traditional">
                <li class="gallerybox" style="width: 155px"><div style="width: 
155px">
-                       <div class="thumb" style="width: 150px;"><div 
style="margin:30px auto;"><div id="mwe_player_6" class="PopUpMediaTransform" 
style="width:120px;" videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_7&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; data-framerate=&quot;30&quot;/&gt;Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.&lt;br /&gt;&#10;You can &lt;a 
href=&quot;http://example.com/images/0/00/Video.ogv&quot;&gt;download the 
clip&lt;/a&gt; or &lt;a 
href=&quot;https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download&quot;&gt;download
 a player&lt;/a&gt; to play the clip in your 
browser.&lt;/video&gt;&lt;/div&gt;"><img alt="File:Video.ogv" 
style="width:120px;height:90px" 
src="http://example.com/images/thumb/0/00/Video.ogv/120px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div></div></div>
+                       <div class="thumb" style="width: 150px;"><div 
style="margin:30px auto;"><div id="mwe_player_6" class="PopUpMediaTransform" 
style="width:120px;" videopayload="&lt;div class=&quot;mediaContainer&quot; 
style=&quot;width:320px&quot;&gt;&lt;video id=&quot;mwe_player_7&quot; 
poster=&quot;http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg&quot;
 controls=&quot;&quot; preload=&quot;none&quot; autoplay=&quot;&quot; 
style=&quot;width:320px;height:240px&quot; class=&quot;kskin&quot; 
data-durationhint=&quot;4.3666666666667&quot; data-startoffset=&quot;0&quot; 
data-mwtitle=&quot;Video.ogv&quot; 
data-mwprovider=&quot;local&quot;&gt;&lt;source 
src=&quot;http://example.com/images/0/00/Video.ogv&quot; type=&quot;video/ogg; 
codecs=&amp;quot;theora&amp;quot;&quot; data-title=&quot;Original Ogg file, 320 
× 240 (590 kbps)&quot; data-shorttitle=&quot;Ogg source&quot; 
data-width=&quot;320&quot; data-height=&quot;240&quot; 
data-bandwidth=&quot;590013&quot; 
data-framerate=&quot;30&quot;/&gt;&lt;/video&gt;&lt;/div&gt;"><img 
alt="File:Video.ogv" style="width:120px;height:90px" 
src="http://example.com/images/thumb/0/00/Video.ogv/120px--Video.ogv.jpg";></img><a
 href="http://example.com/images/0/00/Video.ogv"; title="Play media" 
target="new"><span class="play-btn-large"><span class="mw-tmh-playtext">Play 
media</span></span></a></div></div></div>
                        <div class="gallerytext">
                        </div>
                </div></li>
@@ -50,7 +48,7 @@
 !! wikitext
 [[File:Video.ogv|thumbtime=1:25]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_8" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_8" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! end
 
@@ -59,7 +57,7 @@
 !! wikitext
 [[File:Video.ogv|start=1:25]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_9" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366";>download the 
clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_9" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! end
 
@@ -68,7 +66,7 @@
 !! wikitext
 [[File:Video.ogv|start=1:25|end=1:35]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_10" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366"; 
type="video/ogg; codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 
× 240 (590 kbps)" data-shorttitle="Ogg source" data-width="320" 
data-height="240" data-bandwidth="590013" data-framerate="30"/>Sorry, your 
browser either has JavaScript disabled or does not have any supported 
player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366";>download
 the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_10" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px-seek%3D3.3666666666667-Video.ogv.jpg";
 controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv#t=00:00:03.366,00:00:03.366"; 
type="video/ogg; codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 
× 240 (590 kbps)" data-shorttitle="Ogg source" data-width="320" 
data-height="240" data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! end
 
@@ -77,7 +75,7 @@
 !! wikitext
 [[File:Video.ogv|alt=Test]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_11" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_11" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! end
 
@@ -86,7 +84,7 @@
 !! wikitext
 [[File:Video.ogv|link=Example]]
 !! html
-<div class="mediaContainer" style="width:320px"><video id="mwe_player_12" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/>Sorry, your browser either has 
JavaScript disabled or does not have any supported player.<br /> You can <a 
href="http://example.com/images/0/00/Video.ogv";>download the clip</a> or <a 
href="https://www.mediawiki.org/wiki/Special:MyLanguage/Extension:TimedMediaHandler/Client_download";>download
 a player</a> to play the clip in your browser.</video></div>
+<div class="mediaContainer" style="width:320px"><video id="mwe_player_12" 
poster="http://example.com/images/thumb/0/00/Video.ogv/320px--Video.ogv.jpg"; 
controls="" preload="none" style="width:320px;height:240px" class="kskin" 
data-durationhint="4.3666666666667" data-startoffset="0" 
data-mwtitle="Video.ogv" data-mwprovider="local"><source 
src="http://example.com/images/0/00/Video.ogv"; type="video/ogg; 
codecs=&quot;theora&quot;" data-title="Original Ogg file, 320 × 240 (590 kbps)" 
data-shorttitle="Ogg source" data-width="320" data-height="240" 
data-bandwidth="590013" data-framerate="30"/></video></div>
 
 !! end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/288249
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63f57f6875235221e1ef2c002debbb9527762f31
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: TheDJ <hartman.w...@gmail.com>
Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] Remove fallback content of video/audio tag - change (mediawiki...TimedMediaHandler)

Reply via email to