jenkins-bot has submitted this change and it was merged.
Change subject: uw.controller.Details: Fix 'Uncaught TypeError: Cannot read
property '$element' of undefined'
......................................................................
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element'
of undefined'
Follow-up to 189a5572cc08ac46dc0dba1f7293d5967ee8c7ba.
Bug: T135200
Change-Id: I7fdbccda054d331ad5f88894dc57885d866eeedb
---
M resources/controller/uw.controller.Details.js
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/controller/uw.controller.Details.js
b/resources/controller/uw.controller.Details.js
index b4d4bdc..516e1c3 100644
--- a/resources/controller/uw.controller.Details.js
+++ b/resources/controller/uw.controller.Details.js
@@ -262,7 +262,9 @@
// Disable edit interface
this.ui.disableEdits();
// No way to restore this later... We don't handle
partially-successful uploads very well
- this.copyMetadataWidget.$element.remove();
+ if ( this.copyMetadataWidget ) {
+ this.copyMetadataWidget.$element.remove();
+ }
return this.transitionAll().then( function () {
details.showErrors();
--
To view, visit https://gerrit.wikimedia.org/r/288610
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7fdbccda054d331ad5f88894dc57885d866eeedb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
