Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/288715
Change subject: uw.controller.Details: Fix 'Uncaught TypeError: Cannot read
property '$element' of undefined'
......................................................................
uw.controller.Details: Fix 'Uncaught TypeError: Cannot read property '$element'
of undefined'
Follow-up to 189a5572cc08ac46dc0dba1f7293d5967ee8c7ba.
Bug: T135200
Change-Id: I7fdbccda054d331ad5f88894dc57885d866eeedb
(cherry picked from commit fac5a07c1058fdf314f500cdd361802c61d0a941)
---
M resources/controller/uw.controller.Details.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard
refs/changes/15/288715/1
diff --git a/resources/controller/uw.controller.Details.js
b/resources/controller/uw.controller.Details.js
index b4d4bdc..516e1c3 100644
--- a/resources/controller/uw.controller.Details.js
+++ b/resources/controller/uw.controller.Details.js
@@ -262,7 +262,9 @@
// Disable edit interface
this.ui.disableEdits();
// No way to restore this later... We don't handle
partially-successful uploads very well
- this.copyMetadataWidget.$element.remove();
+ if ( this.copyMetadataWidget ) {
+ this.copyMetadataWidget.$element.remove();
+ }
return this.transitionAll().then( function () {
details.showErrors();
--
To view, visit https://gerrit.wikimedia.org/r/288715
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7fdbccda054d331ad5f88894dc57885d866eeedb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: wmf/1.28.0-wmf.1
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
