Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290225
Change subject: Stylelint: Add duplicate properties rules
......................................................................
Stylelint: Add duplicate properties rules
Change-Id: I8781aef8d05eef11e2734c7baf7288af2500ce39
---
M .stylelintrc
M resources/mobile.notifications.overlay/NotificationsOverlay.less
M resources/mobile.special.mobileoptions.styles/mobileoptions.less
M resources/skins.minerva.base.reset/reset.less
M resources/skins.minerva.base.styles/images.less
M resources/skins.minerva.special.userlogin.styles/userlogin.less
6 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/25/290225/1
diff --git a/.stylelintrc b/.stylelintrc
index 9841c75..7987d68 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -36,6 +36,9 @@
"string-no-newline": true,
"string-quotes": [ "single" ],
+ "declaration-block-no-duplicate-properties": [ true, { ignore:
[ "consecutive-duplicates" ] } ],
+ "declaration-block-no-shorthand-property-overrides": true,
+
"media-query-parentheses-space-inside": [ "always" ]
}
}
diff --git a/resources/mobile.notifications.overlay/NotificationsOverlay.less
b/resources/mobile.notifications.overlay/NotificationsOverlay.less
index 5b51f65..85034b7 100644
--- a/resources/mobile.notifications.overlay/NotificationsOverlay.less
+++ b/resources/mobile.notifications.overlay/NotificationsOverlay.less
@@ -21,7 +21,6 @@
.mw-echo-ui-actionMenuPopupWidget-menu {
padding: 0.5em;
font-size: 1.5em;
- border: 0;
box-shadow: none;
border: 1px solid #666;
// Override the positioning of the menu
diff --git a/resources/mobile.special.mobileoptions.styles/mobileoptions.less
b/resources/mobile.special.mobileoptions.styles/mobileoptions.less
index f8032a9..8c344fb 100644
--- a/resources/mobile.special.mobileoptions.styles/mobileoptions.less
+++ b/resources/mobile.special.mobileoptions.styles/mobileoptions.less
@@ -19,7 +19,6 @@
.option-description {
font-weight: normal;
font-size: 0.8em;
- line-height: 1.8em;
padding-right: 8px;
line-height: 2em;
vertical-align: middle;
diff --git a/resources/skins.minerva.base.reset/reset.less
b/resources/skins.minerva.base.reset/reset.less
index 84acd4a..f748f73 100644
--- a/resources/skins.minerva.base.reset/reset.less
+++ b/resources/skins.minerva.base.reset/reset.less
@@ -17,8 +17,8 @@
margin: 0;
padding: 0;
border: 0;
- font-size: 100%;
font: inherit;
+ font-size: 100%;
vertical-align: baseline;
background: none;
}
diff --git a/resources/skins.minerva.base.styles/images.less
b/resources/skins.minerva.base.styles/images.less
index a8f9205..63f7b7c 100644
--- a/resources/skins.minerva.base.styles/images.less
+++ b/resources/skins.minerva.base.styles/images.less
@@ -4,7 +4,6 @@
@animationDuration: 0.3s;
.lazy-image-placeholder {
- display: inline-block;
// The image placeholder for shouldn't show for no-js devices
.client-nojs & {
display: none;
@@ -20,6 +19,7 @@
// overflowing on smaller images
overflow: hidden;
+ display: inline-block;
// Center spinner vertically and horizontally
display: flex;
justify-content: center;
diff --git a/resources/skins.minerva.special.userlogin.styles/userlogin.less
b/resources/skins.minerva.special.userlogin.styles/userlogin.less
index bfb22b3..080d988 100644
--- a/resources/skins.minerva.special.userlogin.styles/userlogin.less
+++ b/resources/skins.minerva.special.userlogin.styles/userlogin.less
@@ -85,7 +85,6 @@
// CAPTCHA style improvements
.captcha {
- border-radius: 2px;
margin: .8em 0 0;
border: solid 1px @colorGray12;
border-radius: 5px;
--
To view, visit https://gerrit.wikimedia.org/r/290225
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8781aef8d05eef11e2734c7baf7288af2500ce39
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
