Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/290226
Change subject: Stylelint: Add block whitespace and semicolon rules
......................................................................
Stylelint: Add block whitespace and semicolon rules
Change-Id: If4fd415ec4a5ec5f00cb66a9bca8d19b4f2a5f72
---
M .stylelintrc
M minerva.less/minerva.mixins.less
M resources/mobile.drawers/drawer.less
M resources/mobile.overlays/Overlay.less
M resources/mobile.search/SearchOverlay.less
M resources/skins.minerva.base.styles/footer.less
M resources/skins.minerva.base.styles/images.less
7 files changed, 69 insertions(+), 20 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/26/290226/1
diff --git a/.stylelintrc b/.stylelintrc
index 7987d68..176090e 100644
--- a/.stylelintrc
+++ b/.stylelintrc
@@ -39,6 +39,23 @@
"declaration-block-no-duplicate-properties": [ true, { ignore:
[ "consecutive-duplicates" ] } ],
"declaration-block-no-shorthand-property-overrides": true,
+ "declaration-block-semicolon-newline-after": [ "always" ],
+ "declaration-block-semicolon-newline-before": [
"never-multi-line" ],
+ "declaration-block-semicolon-space-after": [
"always-single-line" ],
+ "declaration-block-semicolon-space-before": [ "never" ],
+ "declaration-block-single-line-max-declarations": 1,
+ "declaration-block-trailing-semicolon": [ "always" ],
+
+ "block-closing-brace-newline-after": [ "always" ],
+ "block-closing-brace-newline-before": [ "always-multi-line" ],
+ "block-closing-brace-space-after": [ "always-single-line" ],
+ "block-closing-brace-space-before": [ "always-single-line" ],
+ "block-no-empty": true,
+ "block-no-single-line": true,
+ "block-opening-brace-newline-after": [ "always-multi-line" ],
+ "block-opening-brace-space-after": [ "always-single-line" ],
+ "block-opening-brace-space-before": [ "always" ],
+
"media-query-parentheses-space-inside": [ "always" ]
}
}
diff --git a/minerva.less/minerva.mixins.less b/minerva.less/minerva.mixins.less
index e885e30..5bfc062 100644
--- a/minerva.less/minerva.mixins.less
+++ b/minerva.less/minerva.mixins.less
@@ -8,7 +8,7 @@
.m-background-image( @url ) {
&:after,
&:before {
- .background-image( @url )
+ .background-image( @url );
}
}
diff --git a/resources/mobile.drawers/drawer.less
b/resources/mobile.drawers/drawer.less
index 5ba8248..ece7c4f 100644
--- a/resources/mobile.drawers/drawer.less
+++ b/resources/mobile.drawers/drawer.less
@@ -51,7 +51,7 @@
}
// When overlays are opened drawers do not look good
-.overlay-enabled {
+.overlay-enabled {
.drawer {
// !important to override rules set by animations
display: none !important;
diff --git a/resources/mobile.overlays/Overlay.less
b/resources/mobile.overlays/Overlay.less
index e43a135..d1e4bfe 100644
--- a/resources/mobile.overlays/Overlay.less
+++ b/resources/mobile.overlays/Overlay.less
@@ -186,7 +186,7 @@
> * {
position: absolute;
top: 50%;
- margin-top: -50%
+ margin-top: -50%;
}
}
}
diff --git a/resources/mobile.search/SearchOverlay.less
b/resources/mobile.search/SearchOverlay.less
index ed3d47f..02b5829 100644
--- a/resources/mobile.search/SearchOverlay.less
+++ b/resources/mobile.search/SearchOverlay.less
@@ -108,20 +108,36 @@
}
@-webkit-keyframes fadeIn {
- from { opacity: 0; }
- to { opacity: 1; }
+ from {
+ opacity: 0;
+ }
+ to {
+ opacity: 1;
+ }
}
@keyframes fadeIn {
- from { opacity: 0; }
- to { opacity: 1; }
+ from {
+ opacity: 0;
+ }
+ to {
+ opacity: 1;
+ }
}
@-webkit-keyframes fadeOut {
- from { opacity: 1; }
- to { opacity: 0; }
+ from {
+ opacity: 1;
+ }
+ to {
+ opacity: 0;
+ }
}
@keyframes fadeOut {
- from { opacity: 1; }
- to { opacity: 0; }
+ from {
+ opacity: 1;
+ }
+ to {
+ opacity: 0;
+ }
}
.animations {
.search-overlay {
diff --git a/resources/skins.minerva.base.styles/footer.less
b/resources/skins.minerva.base.styles/footer.less
index bf211e6..6f2903d 100644
--- a/resources/skins.minerva.base.styles/footer.less
+++ b/resources/skins.minerva.base.styles/footer.less
@@ -31,7 +31,7 @@
}
ul {
- display: inline
+ display: inline;
}
ul li,
diff --git a/resources/skins.minerva.base.styles/images.less
b/resources/skins.minerva.base.styles/images.less
index 63f7b7c..525b423 100644
--- a/resources/skins.minerva.base.styles/images.less
+++ b/resources/skins.minerva.base.styles/images.less
@@ -45,19 +45,35 @@
}
@-webkit-keyframes fadeInImage {
- from { opacity: 0 }
- to { opacity: 1 }
+ from {
+ opacity: 0;
+ }
+ to {
+ opacity: 1;
+ }
}
@keyframes fadeInImage {
- from { opacity: 0 }
- to { opacity: 1 }
+ from {
+ opacity: 0;
+ }
+ to {
+ opacity: 1;
+ }
}
@-webkit-keyframes fadeOutContainer {
- from { background-color: @colorGray14 }
- to { background-color: transparent }
+ from {
+ background-color: @colorGray14;
+ }
+ to {
+ background-color: transparent;
+ }
}
@keyframes fadeOutContainer {
- from { background-color: @colorGray14 }
- to { background-color: transparent }
+ from {
+ background-color: @colorGray14;
+ }
+ to {
+ background-color: transparent;
+ }
}
--
To view, visit https://gerrit.wikimedia.org/r/290226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If4fd415ec4a5ec5f00cb66a9bca8d19b4f2a5f72
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
