Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296063
Change subject: Make ext.flaggedRevs.review.css top loading
......................................................................
Make ext.flaggedRevs.review.css top loading
This avoids FOUC and reflow of diff pages
Bug: T138076
Change-Id: I94ddaa8edfa0869db507ae53dcf4b5531400d5f1
---
M frontend/FlaggedRevsUI.hooks.php
M frontend/FlaggedRevsUI.setup.php
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/63/296063/1
diff --git a/frontend/FlaggedRevsUI.hooks.php b/frontend/FlaggedRevsUI.hooks.php
index c474ad4..82da44b 100644
--- a/frontend/FlaggedRevsUI.hooks.php
+++ b/frontend/FlaggedRevsUI.hooks.php
@@ -24,6 +24,7 @@
# Add review form JS for reviewers
if ( $wgUser->isAllowed( 'review' ) ) {
$wgOut->addModules( 'ext.flaggedRevs.review' );
+ $wgOut->addModules( 'ext.flaggedRevs.review.styles' );
}
return true;
}
diff --git a/frontend/FlaggedRevsUI.setup.php b/frontend/FlaggedRevsUI.setup.php
index 3fe5f2d..8f85c2e 100644
--- a/frontend/FlaggedRevsUI.setup.php
+++ b/frontend/FlaggedRevsUI.setup.php
@@ -153,7 +153,6 @@
);
$modules['ext.flaggedRevs.review'] = array(
'scripts' => array( 'ext.flaggedRevs.review.js' ),
- 'styles' => array( 'ext.flaggedRevs.review.css'
),
'messages' => array(
'savearticle', 'tooltip-save',
'revreview-submitedit',
'revreview-submitedit-title',
@@ -168,6 +167,12 @@
'localBasePath' => $localModulePath,
'remoteExtPath' => $remoteModulePath,
);
+ $modules['ext.flaggedRevs.review.styles'] = array(
+ 'styles' => array( 'ext.flaggedRevs.review.css'
),
+ 'localBasePath' => $localModulePath,
+ 'remoteExtPath' => $remoteModulePath,
+ 'position' => 'top',
+ );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/296063
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I94ddaa8edfa0869db507ae53dcf4b5531400d5f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
